Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2424793005: Add key params for buildbotless bots in DM/nanobench (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add key params for buildbotless bots in DM/nanobench BUG=skia:5626 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2424793005 Committed: https://skia.googlesource.com/skia/+/bfa5b455787b9168f363cf58a9e4d94ea93ec5a4

Patch Set 1 #

Patch Set 2 : properties, not key, fix gerrit args #

Patch Set 3 : fix indent #

Patch Set 4 : Add swarming_task_id tag #

Patch Set 5 : Try getting swarming task id in --args? #

Patch Set 6 : Try harder #

Patch Set 7 : Fix flags for test #

Patch Set 8 : Backtrack: assume swarming_task_id is in the environment #

Patch Set 9 : Add swarming_bot_id #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -9 lines) Patch
M infra/bots/recipe_modules/vars/__init__.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipe_modules/vars/api.py View 1 2 3 4 5 6 7 8 4 chunks +34 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_perf.py View 1 2 3 4 5 6 7 8 9 2 chunks +32 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/nobuildbot.json View 1 2 3 4 5 6 7 8 2 chunks +37 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_test.py View 1 2 3 4 5 6 7 8 9 2 chunks +22 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_test.expected/nobuildbot.json View 1 2 3 4 5 6 7 8 9 3 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
borenet
4 years, 2 months ago (2016-10-18 13:19:50 UTC) #3
jcgregorio
lgtm
4 years, 2 months ago (2016-10-18 19:30:39 UTC) #4
borenet
Patch set 9 adds swarming_bot_id in addition to swarming_task_id. This CL depends on https://codereview.chromium.org/2426013002/ which ...
4 years, 2 months ago (2016-10-19 15:24:12 UTC) #5
stephana
On 2016/10/19 15:24:12, borenet wrote: > Patch set 9 adds swarming_bot_id in addition to swarming_task_id. ...
4 years, 2 months ago (2016-10-19 16:34:11 UTC) #6
borenet
Recipe roll landed: https://skia.googlesource.com/skia/+/5e3d9c2e31b61edcfac4fd7b31e98f826d42d9f0
4 years, 2 months ago (2016-10-19 16:35:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424793005/180001
4 years, 2 months ago (2016-10-19 17:03:07 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 17:13:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/bfa5b455787b9168f363cf58a9e4d94ea93ec5a4

Powered by Google App Engine
This is Rietveld 408576698