src/wasm/managed.h - Issue 2424623002: [wasm] Use a Managed<WasmModule> to hold metadata about modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/managed.h

Issue 2424623002: [wasm] Use a Managed<WasmModule> to hold metadata about modules. (Closed)

Patch Set: [wasm] Use a Managed<WasmModule> to hold metadata about modules. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/managed.h

diff --git a/src/wasm/managed.h b/src/wasm/managed.h

index 09ddf60aaa6506d73ac59c20727d613a691b98d6..785d5d32c0ac314349d8f0b5a1ad2ed318a78d06 100644

--- a/src/wasm/managed.h

+++ b/src/wasm/managed.h

@@ -46,6 +46,7 @@ class Managed : public Foreign {

Managed<CppType>** p =

reinterpret_cast<Managed<CppType>**>(data.GetParameter());

delete (*p)->get();

+ (*p)->set_foreign_address(0);

GlobalHandles::Destroy(reinterpret_cast<Object**>(p));

}

};

« no previous file with comments | « src/snapshot/code-serializer.cc ('k') | src/wasm/module-decoder.h » ('j') | no next file with comments »