Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: src/snapshot/code-serializer.h

Issue 2424623002: [wasm] Use a Managed<WasmModule> to hold metadata about modules. (Closed)
Patch Set: [wasm] Use a Managed<WasmModule> to hold metadata about modules. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/signature.h ('k') | src/snapshot/code-serializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/code-serializer.h
diff --git a/src/snapshot/code-serializer.h b/src/snapshot/code-serializer.h
index 7d78bdccdbf1c07f1bfb118944b8e6fc3c9f8b17..61780ec0f860dc17bc1b76b96fb255c82917cebd 100644
--- a/src/snapshot/code-serializer.h
+++ b/src/snapshot/code-serializer.h
@@ -74,7 +74,9 @@ class WasmCompiledModuleSerializer : public CodeSerializer {
}
}
- bool ElideObject(Object* obj) override { return obj->IsWeakCell(); };
+ bool ElideObject(Object* obj) override {
+ return obj->IsWeakCell() || obj->IsForeign();
+ };
private:
WasmCompiledModuleSerializer(Isolate* isolate, uint32_t source_hash)
« no previous file with comments | « src/signature.h ('k') | src/snapshot/code-serializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698