Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2424443003: DevTools: ConsoleViewMessage builders should explicitly add classes (Closed)

Created:
4 years, 2 months ago by luoe
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: ConsoleViewMessage builders should explicitly add classes We're no longer doing this right now. Searching the codebase for 'object-value-" + ' reveals that lots of other places depend on object value classes to work this way. At this time, moving the classes into builders won't be easy without breaking current styles.

Patch Set 1 #

Total comments: 1

Messages

Total messages: 8 (6 generated)
luoe
This was split out from patches 6, 7 in https://codereview.chromium.org/2397933005
4 years, 2 months ago (2016-10-14 18:49:27 UTC) #4
lushnikov
4 years, 2 months ago (2016-10-18 23:15:19 UTC) #7
https://chromiumcodereview.appspot.com/2424443003/diff/1/third_party/WebKit/S...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://chromiumcodereview.appspot.com/2424443003/diff/1/third_party/WebKit/S...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:526:
element.classList.add("object-value-regexp");
object-value-string?

Powered by Google App Engine
This is Rietveld 408576698