Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 24244004: <webview>: Reduce test flake. (Closed)

Created:
7 years, 3 months ago by Fady Samuel
Modified:
7 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

<webview>: Reduce test flake. This CL reduces <webview> test flake by not loading the test web server if the server is not necessary for the test. It also modifies the edit_commands test so that it no longer requires a test server. This CL also re-enables WebViewInteractiveTest.PointerLock_PointerLockLostWithFocus in the hope of having removed flake as it no longer loads a test server. BUG=293445 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224328

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -114 lines) Patch
M chrome/browser/apps/web_view_interactive_browsertest.cc View 1 7 chunks +53 lines, -29 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/edit_commands/embedder.js View 1 5 chunks +14 lines, -18 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/edit_commands/guest.html View 1 chunk +0 lines, -56 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/edit_commands/inject_edit_commands.js View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/navigation/embedder.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Fady Samuel
7 years, 3 months ago (2013-09-19 17:13:08 UTC) #1
lazyboy
lgtm nit: In CL description where it says: "This test also re-enables pointer lock tests ...
7 years, 3 months ago (2013-09-19 17:42:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/24244004/4001
7 years, 3 months ago (2013-09-19 17:44:39 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 07:40:53 UTC) #4
Message was sent while issue was closed.
Change committed as 224328

Powered by Google App Engine
This is Rietveld 408576698