Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2424383002: Make SpellChecker::respondToChangedSelection() to take Position instead of VisibleSelection (Closed)
Patch Set: 2016-10-19T12:54:03 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index df3a10d601da448046f48b3ae3b1b655a928d5b2..8d09b553db8d9a964fabfac0995e8a6f6b3cfd4f 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -304,7 +304,7 @@ void FrameSelection::setSelectionAlgorithm(
const VisibleSelectionTemplate<Strategy> oldSelection =
visibleSelection<Strategy>();
- const VisibleSelection oldSelectionInDOMTree = selection();
+ const Position& oldSelectionStart = selection().start();
m_selectionEditor->setVisibleSelection(s, options);
m_frameCaret->setCaretRectNeedsUpdate();
@@ -350,7 +350,7 @@ void FrameSelection::setSelectionAlgorithm(
m_frame->inputMethodController().cancelCompositionIfSelectionIsInvalid();
return;
}
- m_frame->editor().respondToChangedSelection(oldSelectionInDOMTree, options);
+ m_frame->editor().respondToChangedSelection(oldSelectionStart, options);
if (userTriggered == UserTriggered) {
ScrollAlignment alignment;
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698