third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2424383002: Make SpellChecker::respondToChangedSelection() to take Position instead of VisibleSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2424383002: Make SpellChecker::respondToChangedSelection() to take Position instead of VisibleSelection (Closed)

Patch Set: 2016-10-19T12:54:03 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 2779b19c41197a3ad046474c6eeeb2174742bb07..e3fbaca9d77dbec76d4bd8a5ed1c37e7b86a27c3 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1574,9 +1574,9 @@ void Editor::setMarkedTextMatchesAreHighlighted(bool flag) {

}

void Editor::respondToChangedSelection(

- const VisibleSelection& oldSelection,

+ const Position& oldSelectionStart,

FrameSelection::SetSelectionOptions options) {

- spellChecker().respondToChangedSelection(oldSelection, options);

+ spellChecker().respondToChangedSelection(oldSelectionStart, options);

frame().inputMethodController().cancelCompositionIfSelectionIsInvalid();

client().respondToChangedSelection(&frame(),

frame().selection().getSelectionType());