Make SpellChecker::respondToChangedSelection() to take Position instead of VisibleSelection

Make SpellChecker::respondToChangedSelection() to take Position instead of VisibleSelection

This patch changes |SpellChecker::respondToChangedSelection()| to take start
|Position| of selection instead of |VisibleSelection| for
 - reduce usage of |VisibleSelection|
 - a preparation of http://crrev.com/1958093002, Postpone visible selection
 canonicalization

BUG=625533, 657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/53fdf8113ed9a3998e3f7472d9cb5c5a7b71f3d2
Cr-Commit-Position: refs/heads/master@{#426382}

[yosin_UTC9, 2016-10-18 09:35:21]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 09:35:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-18 09:39:32]

Description was changed from

==========
2016-10-18T18:31:02

BUG=
==========

to

==========
Make SpellChecker::respondToChangedSelection() to take Position instead of
VisibleSelection

This patch changes |SpellChecker::respondToChangedSelection()| to take start
|Position| of selection instead of |VisibleSelection| for
 - reduce usage of |VisibleSelection|
 - a preparation of http://crrev.com/1958093002, Postpone visible selection
 canonicalization

BUG=n/a
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2016-10-18 10:50:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 10:50:47]

Dry run: Exceeded global retry quota

[yosin_UTC9, 2016-10-19 01:06:43]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-19 01:06:44]

PTAL

[Xiaocheng, 2016-10-19 02:08:58]

lgtm with nits.

BTW, do we have a tracking bug for lazy selection validation?

https://codereview.chromium.org/2424383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2424383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:62: bool
isSelectionInTextField(const Position& selectionStart) {
nit: the function should be better renamed to "isPositionInTextField(const
Position& position)"

https://codereview.chromium.org/2424383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:69: bool
isSelectionInTextArea(const Position& selectionStart) {
nit: the function should be better renamed to "isPositionInTextArea(const
Position& position)"

[yosin_UTC9, 2016-10-19 03:38:59]

Description was changed from

==========
Make SpellChecker::respondToChangedSelection() to take Position instead of
VisibleSelection

This patch changes |SpellChecker::respondToChangedSelection()| to take start
|Position| of selection instead of |VisibleSelection| for
 - reduce usage of |VisibleSelection|
 - a preparation of http://crrev.com/1958093002, Postpone visible selection
 canonicalization

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Make SpellChecker::respondToChangedSelection() to take Position instead of
VisibleSelection

This patch changes |SpellChecker::respondToChangedSelection()| to take start
|Position| of selection instead of |VisibleSelection| for
 - reduce usage of |VisibleSelection|
 - a preparation of http://crrev.com/1958093002, Postpone visible selection
 canonicalization

BUG=625533, 657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-19 03:55:26]

Thanks for reviewing!

I put tracking bug numbers in description.

Committing...

https://codereview.chromium.org/2424383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2424383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:62: bool
isSelectionInTextField(const Position& selectionStart) {
On 2016/10/19 at 02:08:58, Xiaocheng wrote:
> nit: the function should be better renamed to "isPositionInTextField(const
Position& position)"

Done

https://codereview.chromium.org/2424383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:69: bool
isSelectionInTextArea(const Position& selectionStart) {
On 2016/10/19 at 02:08:58, Xiaocheng wrote:
> nit: the function should be better renamed to "isPositionInTextArea(const
Position& position)"

Done.

[yosin_UTC9, 2016-10-19 03:55:30]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-19 03:55:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2424383002/#ps20001
(title: "2016-10-19T12:54:03")

[commit-bot: I haz the power, 2016-10-19 03:56:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 06:00:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 06:00:42]

Exceeded global retry quota

[yosin_UTC9, 2016-10-20 01:23:46]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-20 01:24:11]

The CQ bit was unchecked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-20 01:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-20 01:24:14]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-20 01:25:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 03:27:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:14:49]

Description was changed from

==========
Make SpellChecker::respondToChangedSelection() to take Position instead of
VisibleSelection

This patch changes |SpellChecker::respondToChangedSelection()| to take start
|Position| of selection instead of |VisibleSelection| for
 - reduce usage of |VisibleSelection|
 - a preparation of http://crrev.com/1958093002, Postpone visible selection
 canonicalization

BUG=625533, 657237
TEST=n/a; no behavior changes
==========

to

==========
Make SpellChecker::respondToChangedSelection() to take Position instead of
VisibleSelection

This patch changes |SpellChecker::respondToChangedSelection()| to take start
|Position| of selection instead of |VisibleSelection| for
 - reduce usage of |VisibleSelection|
 - a preparation of http://crrev.com/1958093002, Postpone visible selection
 canonicalization

BUG=625533, 657237
TEST=n/a; no behavior changes

Committed: https://crrev.com/53fdf8113ed9a3998e3f7472d9cb5c5a7b71f3d2
Cr-Commit-Position: refs/heads/master@{#426382}
==========

[commit-bot: I haz the power, 2016-10-21 13:14:50]

Patchset 2 (id:??) landed as
https://crrev.com/53fdf8113ed9a3998e3f7472d9cb5c5a7b71f3d2
Cr-Commit-Position: refs/heads/master@{#426382}