Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 24243015: Pointing to a skia master domain name and reading list of required build steps from the master. (Closed)

Created:
7 years, 3 months ago by rmistry
Modified:
7 years, 3 months ago
Reviewers:
Isaac (away), iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, skiabot_google.com
Base URL:
https://src.chromium.org/chrome/trunk/tools/commit-queue/
Visibility:
Public.

Description

Pointing to a skia master domain name and reading list of required build steps from the master. Note: The Skia CQ will have to be resynced and restarted after this goes in. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=224610

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M projects.py View 1 1 chunk +6 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rmistry
7 years, 3 months ago (2013-09-20 12:45:37 UTC) #1
Isaac (away)
This directory doesn't appear to have owners. However, this CL seems a bit concerning, given ...
7 years, 3 months ago (2013-09-20 13:28:25 UTC) #2
rmistry
On 2013/09/20 13:28:25, Isaac wrote: > This directory doesn't appear to have owners. However, this ...
7 years, 3 months ago (2013-09-20 13:33:42 UTC) #3
rmistry
7 years, 3 months ago (2013-09-20 15:14:34 UTC) #4
iannucci
Yeah we should move this to real domain... Maybe add a comment to this effect?
7 years, 3 months ago (2013-09-20 18:37:07 UTC) #5
rmistry
Agreed. I think it is a couple of weeks away from being ready.
7 years, 3 months ago (2013-09-20 18:53:15 UTC) #6
rmistry
Added the comment.
7 years, 3 months ago (2013-09-20 18:53:39 UTC) #7
iannucci
lgtm
7 years, 3 months ago (2013-09-21 18:16:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmistry@google.com/24243015/8001
7 years, 3 months ago (2013-09-21 19:16:56 UTC) #9
commit-bot: I haz the power
Change committed as 224610
7 years, 3 months ago (2013-09-21 19:17:19 UTC) #10
rmistry
Thanks Robbie, could you please resync and restart the Skia CQ?
7 years, 3 months ago (2013-09-21 19:17:58 UTC) #11
iannucci
On 2013/09/21 19:17:58, rmistry wrote: > Thanks Robbie, could you please resync and restart the ...
7 years, 3 months ago (2013-09-21 19:43:31 UTC) #12
rmistry
7 years, 3 months ago (2013-09-21 19:50:24 UTC) #13
Message was sent while issue was closed.
On 2013/09/21 19:43:31, iannucci wrote:
> On 2013/09/21 19:17:58, rmistry wrote:
> > Thanks Robbie, could you please resync and restart the Skia CQ?
> 
> done and done :)

Thanks!

Powered by Google App Engine
This is Rietveld 408576698