chrome/test/data/flash_embeds.html - Issue 2424293002: Fix <object data=> YouTube Flash rewrites.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/flash_embeds.html

Issue 2424293002: Fix <object data=> YouTube Flash rewrites. (Closed)

Patch Set: Changed the setup method to the one running on the main thread? Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head></head>	3 <head></head>

4 <body>	4 <body>

5 </body>	5 </body>

6 <script>	6 <script>

7 function appendToDOM(url, type) {	7 function appendEmbedToDOM(url, type) {

8 var object = document.createElement("object");	8 var object = document.createElement("object");

9 var embed = document.createElement("embed");	9 var embed = document.createElement("embed");

10 embed.src = url;	10 embed.src = url;

11 embed.setAttribute("type", type);	11 embed.setAttribute("type", type);

12 object.appendChild(embed);	12 object.appendChild(embed);

13 document.body.appendChild(object);	13 document.body.appendChild(object);

14 }	14 }

	15

	16 function appendDataEmbedToDOM(url, type) {

	17 var object = document.createElement("object");

	18 object.setAttribute("data", url);

	19 object.setAttribute("type", type);

	20 document.body.appendChild(object);

	21 }

15 </script>	22 </script>

16 </html>	23 </html>

OLD	NEW