Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2424293002: Fix <object data=> YouTube Flash rewrites. (Closed)

Created:
4 years, 2 months ago by whywhat
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix <object data=> YouTube Flash rewrites. Some YouTube videos are embedded via <object data="http://www.youtube.com/v/AABBCCDD">. Chrome currently only rewrites embeds that use <embed src="http://www.youtube.com/v/AABBCCDD"> The CL adds the logic for rewriting YouTube Flash plugin embed URLs with HTML5 embeds to the HTMLObjectElement (this matches Firefox behavior). Trying to reland https://codereview.chromium.org/2416253002. Split the browser test into 10 separate test cases trying to avoid OOM on Debug ChromiumOS builder. BUG=655988 TEST=manual + updated browser tests Committed: https://crrev.com/3efdec3c23c4fb82b88803d65daf114beae5553d Cr-Commit-Position: refs/heads/master@{#426223}

Patch Set 1 #

Patch Set 2 : Initialize the message loop in setup. #

Patch Set 3 : Changed the setup method to the one running on the main thread? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -55 lines) Patch
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 1 2 2 chunks +94 lines, -54 lines 0 comments Download
M chrome/test/data/flash_embeds.html View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
whywhat
Initialize the message loop in setup.
4 years, 2 months ago (2016-10-18 22:08:44 UTC) #1
whywhat
Changed the setup method to the one running on the main thread?
4 years, 2 months ago (2016-10-19 01:38:30 UTC) #2
whywhat
PTaL Seems like the chromeos dbg trybot is passing now (the analog bot failed on ...
4 years, 2 months ago (2016-10-19 02:57:26 UTC) #4
mlamouri (slow - plz ping)
some bots are still failing but rs lgtm
4 years, 2 months ago (2016-10-19 09:31:32 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-19 14:21:59 UTC) #10
whywhat
On 2016/10/19 at 09:31:32, mlamouri wrote: > some bots are still failing but rs lgtm ...
4 years, 2 months ago (2016-10-19 15:04:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424293002/40001
4 years, 2 months ago (2016-10-19 15:05:19 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-19 16:43:59 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 13:09:25 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3efdec3c23c4fb82b88803d65daf114beae5553d
Cr-Commit-Position: refs/heads/master@{#426223}

Powered by Google App Engine
This is Rietveld 408576698