arc: Add clip_data_uri field to IntentInfo struct.

arc: Add clip_data_uri field to IntentInfo struct.

Add an optional clip_data_uri field to the IntentInfo
struct. It can be used to supply a URI to be attached to the
intent as ClipData.

BUG=647802
Committed: https://crrev.com/729a1d8fa4f04d91c9a251e0867c8ba9a8ed4bd8
Cr-Commit-Position: refs/heads/master@{#426542}

[Daniel Erat, 2016-10-18 01:36:12]

derat@chromium.org changed reviewers:
+ dcheng@chromium.org, kinaba@chromium.org, yusukes@chromium.org

[Daniel Erat, 2016-10-18 01:36:13]

(i think that this change is in the same boat as my earlier one in not being
able to use a more-specific type than "string" due to arc not wanting to pull in
dependencies.)

[Daniel Erat, 2016-10-18 01:36:18]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 01:36:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 02:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 02:02:33]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-10-18 15:42:38]

lgtm

[dcheng, 2016-10-19 05:43:00]

mojom lgtm

I talked to rockot about the types here, and I think we should try to clean up
the various untyped things in ARC++. We can something similar to ArcBitmap
(which is typemapped to SkBitmap) and introduce an ArcUrl type which we can
typemap to GURL. Does that seem like a reasonable followup?

[Daniel Erat, 2016-10-20 17:40:04]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-10-20 17:40:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-10-20 17:41:59]

On 2016/10/19 05:43:00, dcheng wrote:
> mojom lgtm
> 
> I talked to rockot about the types here, and I think we should try to clean up
> the various untyped things in ARC++. We can something similar to ArcBitmap
> (which is typemapped to SkBitmap) and introduce an ArcUrl type which we can
> typemap to GURL. Does that seem like a reasonable followup?

re introducing types, sounds good to me. i'm a newcomer to all of this, so i'll
let other people comment on whether it's feasible for the android side of this
to deal with GURLs.

[dcheng, 2016-10-20 17:46:42]

On 2016/10/20 17:41:59, Daniel Erat wrote:
> On 2016/10/19 05:43:00, dcheng wrote:
> > mojom lgtm
> > 
> > I talked to rockot about the types here, and I think we should try to clean
up
> > the various untyped things in ARC++. We can something similar to ArcBitmap
> > (which is typemapped to SkBitmap) and introduce an ArcUrl type which we can
> > typemap to GURL. Does that seem like a reasonable followup?
> 
> re introducing types, sounds good to me. i'm a newcomer to all of this, so
i'll
> let other people comment on whether it's feasible for the android side of this
> to deal with GURLs.

The Android-side would deal with ArcUrlPtr I guess (assuming it's using native).
Just the Chromium-side would use GURL: my understanding is the ARC++ Android
implementation is trying to minimize its external dependencies on Chromium code
itself.

[commit-bot: I haz the power, 2016-10-20 18:46:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:20:36]

Description was changed from

==========
arc: Add clip_data_uri field to IntentInfo struct.

Add an optional clip_data_uri field to the IntentInfo
struct. It can be used to supply a URI to be attached to the
intent as ClipData.

BUG=647802
==========

to

==========
arc: Add clip_data_uri field to IntentInfo struct.

Add an optional clip_data_uri field to the IntentInfo
struct. It can be used to supply a URI to be attached to the
intent as ClipData.

BUG=647802

Committed: https://crrev.com/729a1d8fa4f04d91c9a251e0867c8ba9a8ed4bd8
Cr-Commit-Position: refs/heads/master@{#426542}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:37]

Patchset 1 (id:??) landed as
https://crrev.com/729a1d8fa4f04d91c9a251e0867c8ba9a8ed4bd8
Cr-Commit-Position: refs/heads/master@{#426542}