Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: components/security_state/security_state_model_unittest.cc

Issue 2424223002: Update devtools security panel for HTTP-bad (Closed)
Patch Set: lgarron comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/security_state/security_state_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/security_state/security_state_model_unittest.cc
diff --git a/components/security_state/security_state_model_unittest.cc b/components/security_state/security_state_model_unittest.cc
index a49ba1f8972f0cd3d1c786ce079cad386b703e14..59d668b78374a541c1c39f7627663395b7ce975f 100644
--- a/components/security_state/security_state_model_unittest.cc
+++ b/components/security_state/security_state_model_unittest.cc
@@ -250,6 +250,7 @@ TEST(SecurityStateModelTest, PasswordFieldWarning) {
client.set_displayed_password_field_on_http(true);
SecurityStateModel::SecurityInfo security_info;
model.GetSecurityInfo(&security_info);
+ EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
EXPECT_EQ(SecurityStateModel::HTTP_SHOW_WARNING,
security_info.security_level);
}
@@ -267,6 +268,7 @@ TEST(SecurityStateModelTest, CreditCardFieldWarning) {
client.set_displayed_credit_card_field_on_http(true);
SecurityStateModel::SecurityInfo security_info;
model.GetSecurityInfo(&security_info);
+ EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
EXPECT_EQ(SecurityStateModel::HTTP_SHOW_WARNING,
security_info.security_level);
}
@@ -283,6 +285,20 @@ TEST(SecurityStateModelTest, HttpWarningNotSetWithoutSwitch) {
client.set_displayed_credit_card_field_on_http(true);
SecurityStateModel::SecurityInfo security_info;
model.GetSecurityInfo(&security_info);
+ EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
+ EXPECT_EQ(SecurityStateModel::NONE, security_info.security_level);
+}
+
+// Tests that |displayed_private_user_data_input_on_http| is not set
+// when the corresponding VisibleSecurityState flags are not set.
+TEST(SecurityStateModelTest, PrivateUserDataNotSet) {
+ TestSecurityStateModelClient client;
+ client.UseHttpUrl();
+ SecurityStateModel model;
+ model.SetClient(&client);
+ SecurityStateModel::SecurityInfo security_info;
+ model.GetSecurityInfo(&security_info);
+ EXPECT_FALSE(security_info.displayed_private_user_data_input_on_http);
EXPECT_EQ(SecurityStateModel::NONE, security_info.security_level);
}
« no previous file with comments | « components/security_state/security_state_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698