media: Use native CipherMode enum type in media mojo interfaces

media: Use native CipherMode enum type in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9
Cr-Commit-Position: refs/heads/master@{#425806}

[xhwang, 2016-10-15 09:10:29]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 09:10:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-15 09:13:59]

xhwang@chromium.org changed reviewers:
+ rockot@chromium.org

[xhwang, 2016-10-15 09:14:00]

rockot: I have a question. Could you please help take a look?

https://chromiumcodereview.appspot.com/2423703002/diff/1/media/base/encryptio...
File media/base/encryption_scheme.h (right):

https://chromiumcodereview.appspot.com/2423703002/diff/1/media/base/encryptio...
media/base/encryption_scheme.h:89: }  // namespace std
+rockot

I have to add this, otherwise, the linker complains that:

../../mojo/public/cpp/bindings/lib/hash_util.h:22: error: undefined reference to
'std::hash<media::EncryptionScheme::CipherMode>::operator()(media::EncryptionScheme::CipherMode)
const'

I guess this is because I use this native enum in a mojom stuct (see the diff in
media_types.mojom), but this is my pure guess.

Do you see anything obvious what went wrong?

[commit-bot: I haz the power, 2016-10-15 09:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 09:46:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-10-15 15:35:29]

https://codereview.chromium.org/2423703002/diff/1/media/base/encryption_scheme.h
File media/base/encryption_scheme.h (right):

https://codereview.chromium.org/2423703002/diff/1/media/base/encryption_schem...
media/base/encryption_scheme.h:89: }  // namespace std
On 2016/10/15 at 09:13:59, xhwang wrote:
> +rockot
> 
> I have to add this, otherwise, the linker complains that:
> 
> ../../mojo/public/cpp/bindings/lib/hash_util.h:22: error: undefined reference
to
'std::hash<media::EncryptionScheme::CipherMode>::operator()(media::EncryptionScheme::CipherMode)
const'
> 
> I guess this is because I use this native enum in a mojom stuct (see the diff
in media_types.mojom), but this is my pure guess.
> 
> Do you see anything obvious what went wrong?

I think this will do it: https://codereview.chromium.org/2415293004

[xhwang, 2016-10-16 02:51:30]

On 2016/10/15 15:35:29, Ken Rockot wrote:
>
https://codereview.chromium.org/2423703002/diff/1/media/base/encryption_scheme.h
> File media/base/encryption_scheme.h (right):
> 
>
https://codereview.chromium.org/2423703002/diff/1/media/base/encryption_schem...
> media/base/encryption_scheme.h:89: }  // namespace std
> On 2016/10/15 at 09:13:59, xhwang wrote:
> > +rockot
> > 
> > I have to add this, otherwise, the linker complains that:
> > 
> > ../../mojo/public/cpp/bindings/lib/hash_util.h:22: error: undefined
reference
> to
>
'std::hash<media::EncryptionScheme::CipherMode>::operator()(media::EncryptionScheme::CipherMode)
> const'
> > 
> > I guess this is because I use this native enum in a mojom stuct (see the
diff
> in media_types.mojom), but this is my pure guess.
> > 
> > Do you see anything obvious what went wrong?
> 
> I think this will do it: https://codereview.chromium.org/2415293004

Cool. Thanks!

[xhwang, 2016-10-17 16:53:42]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 16:54:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-17 16:54:32]

Description was changed from

==========
media: Use native CDM enum types in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native CipherMode enum type in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass
==========

[xhwang, 2016-10-17 18:31:04]

xhwang@chromium.org changed reviewers:
+ dcheng@chromium.org, jrummell@chromium.org

[xhwang, 2016-10-17 18:31:05]

dcheng / jrummell: Another one, PTAL

FYI: I put this in a separate small CL so that rockot@ can help fix the mojo
issue (see previous comment)

[jrummell, 2016-10-17 20:17:54]

lgtm w/nit

https://codereview.chromium.org/2423703002/diff/20001/media/mojo/interfaces/m...
File media/mojo/interfaces/media_types.typemap (right):

https://codereview.chromium.org/2423703002/diff/20001/media/mojo/interfaces/m...
media/mojo/interfaces/media_types.typemap:37:
"media.mojom.EncryptionScheme.CipherMode=media::EncryptionScheme::CipherMode",
Should this be in alphabetical order?

[commit-bot: I haz the power, 2016-10-17 20:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 20:18:41]

Dry run: This issue passed the CQ dry run.

[xhwang, 2016-10-17 21:36:06]

rebase only

[xhwang, 2016-10-17 21:37:20]

https://chromiumcodereview.appspot.com/2423703002/diff/20001/media/mojo/inter...
File media/mojo/interfaces/media_types.typemap (right):

https://chromiumcodereview.appspot.com/2423703002/diff/20001/media/mojo/inter...
media/mojo/interfaces/media_types.typemap:37:
"media.mojom.EncryptionScheme.CipherMode=media::EncryptionScheme::CipherMode",
On 2016/10/17 20:17:54, jrummell wrote:
> Should this be in alphabetical order?

Done.

[xhwang, 2016-10-17 21:37:24]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 21:38:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-17 22:34:43]

lgtm

[xhwang, 2016-10-17 22:54:05]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2016-10-17 22:54:05]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-10-17 22:54:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2423703002/#ps60001
(title: "media: Use native CDM enum types in media mojo interfaces")

[commit-bot: I haz the power, 2016-10-17 22:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 23:12:20]

Description was changed from

==========
media: Use native CipherMode enum type in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native CipherMode enum type in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass
==========

[commit-bot: I haz the power, 2016-10-17 23:12:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-17 23:15:17]

Description was changed from

==========
media: Use native CipherMode enum type in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native CipherMode enum type in media mojo interfaces

BUG=611224
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9
Cr-Commit-Position: refs/heads/master@{#425806}
==========

[commit-bot: I haz the power, 2016-10-17 23:15:18]

Patchset 4 (id:??) landed as
https://crrev.com/90b6ba65d65fe5cb01b137dbdee9e60b689d84e9
Cr-Commit-Position: refs/heads/master@{#425806}