Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: third_party/WebKit/Source/core/loader/ImageLoader.cpp

Issue 2423683002: Add Blink support for showing image placeholders using range requests. (Closed)
Patch Set: Addressed comments and fixed bugs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/ImageLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/ImageLoader.cpp b/third_party/WebKit/Source/core/loader/ImageLoader.cpp
index 296a26d1d3ed5e4277e875d80a80ea782b5c9407..0b4c8d75e7bee06524b1e355e3fff8949bbee1d9 100644
--- a/third_party/WebKit/Source/core/loader/ImageLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/ImageLoader.cpp
@@ -313,6 +313,12 @@ void ImageLoader::doUpdateFromElement(BypassMainWorldBehavior bypassBehavior,
configureRequest(request, bypassBehavior, *m_element,
document.clientHintsPreferences());
+ request.setPlaceholderImageRequestType(
+ updateBehavior != UpdateForcedReload && document.settings() &&
+ document.settings()->fetchImagePlaceholders()
+ ? FetchRequest::AllowPlaceholder
+ : FetchRequest::DisallowPlaceholder);
+
newImage = ImageResource::fetch(request, document.fetcher());
if (!newImage && !pageIsBeingDismissed(&document)) {

Powered by Google App Engine
This is Rietveld 408576698