Simplify incremental paint invalidation

Simplify incremental paint invalidation

- Incremental paint invalidation now applies to LayoutBoxes only. For
  other objects, do full paint invalidation.

- Do full paint invalidation if the object has border radius.

- Simplfied code for incremental paint invalidation.

This will simplify spv2 raster invalidation when we implement
the same incremental invalidation as spv1.

Also make it ready for slimmingPaintInvalidation paint invalidation
rect subpixel snapping. Will change the extraWidth/extraHeight
parameter from 0 to 1 for slimmingPaintInvalidation to ensure the
subpixel along the edge of the delta between the old/new rects.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7ef32bf9ec1c65dc679f54ea9c686976616e87f2
Cr-Commit-Position: refs/heads/master@{#426914}

[Xianzhu, 2016-10-14 19:30:19]

Description was changed from

==========
Simplify incremental paint invalidation

- Incremental paint invalidation now applies to LayoutBoxes only. For
  other objects, do full paint invalidation.

- Do full paint invalidation if the object has border radius.

- Simplfied code for incremental paint invalidation.

This will simplify spv2 raster invalidation when we implement
the same incremental invalidation as spv1.

Also make it ready for slimmingPaintInvalidation paint invalidation
rect subpixel snapping. Will change the extraWidth/extraHeight
parameter from 0 to 1 for slimmingPaintInvalidation to ensure the
subpixel along the edge of the delta between the old/new rects.
==========

to

==========
Simplify incremental paint invalidation

- Incremental paint invalidation now applies to LayoutBoxes only. For
  other objects, do full paint invalidation.

- Do full paint invalidation if the object has border radius.

- Simplfied code for incremental paint invalidation.

This will simplify spv2 raster invalidation when we implement
the same incremental invalidation as spv1.

Also make it ready for slimmingPaintInvalidation paint invalidation
rect subpixel snapping. Will change the extraWidth/extraHeight
parameter from 0 to 1 for slimmingPaintInvalidation to ensure the
subpixel along the edge of the delta between the old/new rects.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-10-14 19:33:28]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 19:33:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 21:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 21:08:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-10-14 22:34:29]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-10-14 22:34:30]

I have checked the layout test results. All of them look legit except for
paint/invalidation/fixed-under-composited-absolute-scrolled.html which now has
an unexpected over-invalidation because of crbug.com/656172.

[Xianzhu, 2016-10-20 16:36:31]

ping...

[chrishtr, 2016-10-20 18:15:44]

https://codereview.chromium.org/2423513002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp (right):

https://codereview.chromium.org/2423513002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp:68:
DCHECK(m_context.oldBounds.location() == m_context.newBounds.location());
Could you add unittests to the geometric logic here?

[Xianzhu, 2016-10-21 00:18:26]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 00:19:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-10-21 00:19:49]

https://codereview.chromium.org/2423513002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp (right):

https://codereview.chromium.org/2423513002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp:68:
DCHECK(m_context.oldBounds.location() == m_context.newBounds.location());
On 2016/10/20 18:15:44, chrishtr wrote:
> Could you add unittests to the geometric logic here?

Done.

[commit-bot: I haz the power, 2016-10-21 02:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 02:16:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-10-21 17:18:27]

https://codereview.chromium.org/2423513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp (right):

https://codereview.chromium.org/2423513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp:52:
EXPECT_EQ(IntRect(60, 0, 60, 240), (*rasterInvalidations)[0].rect);
Check that the paint invalidation reason matches also, and in the tests below.

[Xianzhu, 2016-10-21 17:53:18]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2016-10-21 17:53:38]

https://codereview.chromium.org/2423513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp (right):

https://codereview.chromium.org/2423513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp:52:
EXPECT_EQ(IntRect(60, 0, 60, 240), (*rasterInvalidations)[0].rect);
On 2016/10/21 17:18:27, chrishtr wrote:
> Check that the paint invalidation reason matches also, and in the tests below.

Done.

[commit-bot: I haz the power, 2016-10-21 17:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-10-21 17:55:20]

lgtm

[commit-bot: I haz the power, 2016-10-21 22:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:01:10]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-10-21 22:01:37]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-10-21 22:02:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 22:19:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 22:26:27]

Description was changed from

==========
Simplify incremental paint invalidation

- Incremental paint invalidation now applies to LayoutBoxes only. For
  other objects, do full paint invalidation.

- Do full paint invalidation if the object has border radius.

- Simplfied code for incremental paint invalidation.

This will simplify spv2 raster invalidation when we implement
the same incremental invalidation as spv1.

Also make it ready for slimmingPaintInvalidation paint invalidation
rect subpixel snapping. Will change the extraWidth/extraHeight
parameter from 0 to 1 for slimmingPaintInvalidation to ensure the
subpixel along the edge of the delta between the old/new rects.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Simplify incremental paint invalidation

- Incremental paint invalidation now applies to LayoutBoxes only. For
  other objects, do full paint invalidation.

- Do full paint invalidation if the object has border radius.

- Simplfied code for incremental paint invalidation.

This will simplify spv2 raster invalidation when we implement
the same incremental invalidation as spv1.

Also make it ready for slimmingPaintInvalidation paint invalidation
rect subpixel snapping. Will change the extraWidth/extraHeight
parameter from 0 to 1 for slimmingPaintInvalidation to ensure the
subpixel along the edge of the delta between the old/new rects.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7ef32bf9ec1c65dc679f54ea9c686976616e87f2
Cr-Commit-Position: refs/heads/master@{#426914}
==========

[commit-bot: I haz the power, 2016-10-21 22:26:29]

Patchset 3 (id:??) landed as
https://crrev.com/7ef32bf9ec1c65dc679f54ea9c686976616e87f2
Cr-Commit-Position: refs/heads/master@{#426914}