Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2423403002: Set logical top and height of table rows and cells in the first layout pass. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set logical top and height of table rows and cells in the first layout pass. This gives the fragmentation machinery an opportunity to insert breaks at the right places. We previously assumed that all cells were at the top of their table section, so break insertion was completely bogus. While we'd get a second chance to break correctly in the second layout pass, this doesn't always work too well. There's currently some code in layoutRows() in LayoutTableSection that attempts to adjust the row height when we change where we break inside a table cell, but it doesn't re-align cells vertically after this adjustment. That code must die, and this CL is a preparatory step. BUG=534751 Committed: https://crrev.com/0f36142505fcc4bc9b2f3518649befd2b5cbc63f Cr-Commit-Position: refs/heads/master@{#426015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/break-in-first-table-row-only.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/break-in-first-table-row-only-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 3 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-18 17:11:14 UTC) #6
eae
LGTM
4 years, 2 months ago (2016-10-18 18:04:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423403002/1
4 years, 2 months ago (2016-10-18 18:47:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 18:57:12 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:02:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f36142505fcc4bc9b2f3518649befd2b5cbc63f
Cr-Commit-Position: refs/heads/master@{#426015}

Powered by Google App Engine
This is Rietveld 408576698