Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 24234002: Use IO loop for the compositor and media threads in the renderer on posix. (Closed)

Created:
7 years, 3 months ago by piman
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, darin (slow to review)
Visibility:
Public.

Description

Use IO loop for the compositor thread in the renderer on posix. MessagePumpDefault breaks PostDelayedTask on posix because it uses system time. MessagePumpIO uses monotonic time, so is immune to these problems. (These threads because they schedule things with PostDelayedTask). BUG=293736 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224074

Patch Set 1 #

Patch Set 2 : also do the media thread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M content/renderer/render_thread_impl.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
-fischman +scherkus
7 years, 3 months ago (2013-09-18 21:09:58 UTC) #1
jamesr
Hm, are there any threads that don't schedule work with PostDelayedTask()? Seems like we should ...
7 years, 3 months ago (2013-09-18 21:12:13 UTC) #2
piman
On Wed, Sep 18, 2013 at 2:12 PM, <jamesr@chromium.org> wrote: > Hm, are there any ...
7 years, 3 months ago (2013-09-18 21:14:55 UTC) #3
jamesr
lgtm
7 years, 3 months ago (2013-09-18 21:31:09 UTC) #4
scherkus (not reviewing)
chatted w/ fischman about this offline lgtm
7 years, 3 months ago (2013-09-18 22:23:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/24234002/4001
7 years, 3 months ago (2013-09-18 22:35:29 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 07:18:16 UTC) #7
Message was sent while issue was closed.
Change committed as 224074

Powered by Google App Engine
This is Rietveld 408576698