Issue 2423353002: Reduce usage of FOR_EACH_OBSERVER macro in components/

Issue 2423353002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers

Modified:
4 years, 2 months ago

Reviewers:
xiyuan

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Reduce usage of FOR_EACH_OBSERVER macro in components/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872 Cr-Commit-Position: refs/heads/master@{#426114}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -69 lines)			Patch
M	components/proximity_auth/connection.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	components/proximity_auth/cryptauth/cryptauth_device_manager.cc	View	3 chunks	+10 lines, -9 lines	0 comments	Download
M	components/proximity_auth/cryptauth/cryptauth_enrollment_manager.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	components/proximity_auth/cryptauth/mock_cryptauth_client.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/proximity_auth/logging/log_buffer.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	components/proximity_auth/messenger_impl.cc	View	7 chunks	+20 lines, -16 lines	0 comments	Download
M	components/proximity_auth/proximity_monitor_impl.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	components/proximity_auth/remote_device_life_cycle_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/proximity_auth/screenlock_bridge.cc	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	components/user_manager/user_manager_base.cc	View	3 chunks	+10 lines, -14 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423353002/1

4 years, 2 months ago (2016-10-18 22:44:29 UTC) #5

commit-bot: I haz the power

4 years, 2 months ago (2016-10-21 13:05:43 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fe109cda61d666ccbc0c32f068a82284ff971872
Cr-Commit-Position: refs/heads/master@{#426114}