Bug Fix: Cursor Stretched During Tab Capturing On Windows

Bug Fix: Cursor Stretched During Tab Capturing On Windows

On Windows 10, the mouse cursor is vertically stretched during
screen capturing.

This CL fixes the bug.

BUG=655198
Committed: https://crrev.com/b5f188496d88bbef4ec99ee84742f61380f8516e
Cr-Commit-Position: refs/heads/master@{#426589}

[qiangchen, 2016-10-18 20:06:57]

The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 20:07:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qiangchen, 2016-10-18 20:11:33]

Description was changed from

==========
Bug Fix: Icon Stretched During Tab Capturing On Windows

BUG=
==========

to

==========
Bug Fix: Cursor Stretched During Tab Capturing On Windows

On Windows 10, the mouse cursor is vertically stretched during
screen capturing. 

This CL fixes the bug.

BUG=655198
==========

[qiangchen, 2016-10-18 20:16:39]

qiangchen@chromium.org changed reviewers:
+ danakj@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:29:23]

Dry run: This issue passed the CQ dry run.

[qiangchen, 2016-10-18 21:30:24]

Can you take a look? Thanks.

[qiangchen, 2016-10-20 17:21:41]

qiangchen@chromium.org changed reviewers:
+ msw@chromium.org
- danakj@chromium.org

[qiangchen, 2016-10-20 17:25:07]

Can you take a look at this CL?

[msw, 2016-10-20 18:54:51]

Good catch; lgtm with a nit.

https://codereview.chromium.org/2423293003/diff/1/ui/gfx/icon_util.cc
File ui/gfx/icon_util.cc (right):

https://codereview.chromium.org/2423293003/diff/1/ui/gfx/icon_util.cc#newcode317
ui/gfx/icon_util.cc:317: const int height = (icon_info.hbmColor == NULL) ?
bitmap_info.bmHeight / 2
nit: just check: "icon_info.hbmColor ?" otherwise, use nullptr. optionally:
  const int height = bitmap_info.bmHeight / (icon_info.hbmColor ? 2 : 1);

[qiangchen, 2016-10-20 20:03:30]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2016-10-20 20:03:30]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2423293003/#ps20001
(title: "nit")

[qiangchen, 2016-10-20 20:03:34]

https://codereview.chromium.org/2423293003/diff/1/ui/gfx/icon_util.cc
File ui/gfx/icon_util.cc (right):

https://codereview.chromium.org/2423293003/diff/1/ui/gfx/icon_util.cc#newcode317
ui/gfx/icon_util.cc:317: const int height = (icon_info.hbmColor == NULL) ?
bitmap_info.bmHeight / 2
On 2016/10/20 18:54:51, msw wrote:
> nit: just check: "icon_info.hbmColor ?" otherwise, use nullptr. optionally:
>   const int height = bitmap_info.bmHeight / (icon_info.hbmColor ? 2 : 1);

Done.

[commit-bot: I haz the power, 2016-10-20 20:03:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-20 20:06:58]

still lgtm

https://chromiumcodereview.appspot.com/2423293003/diff/1/ui/gfx/icon_util.cc
File ui/gfx/icon_util.cc (right):

https://chromiumcodereview.appspot.com/2423293003/diff/1/ui/gfx/icon_util.cc#...
ui/gfx/icon_util.cc:317: const int height = (icon_info.hbmColor == NULL) ?
bitmap_info.bmHeight / 2
On 2016/10/20 20:03:33, qiangchenC wrote:
> On 2016/10/20 18:54:51, msw wrote:
> > nit: just check: "icon_info.hbmColor ?" otherwise, use nullptr. optionally:
> >   const int height = bitmap_info.bmHeight / (icon_info.hbmColor ? 2 : 1);
> 
> Done.

Thanks for catching and fixing the inversion error in my suggested ternary!

[commit-bot: I haz the power, 2016-10-20 20:55:06]

Description was changed from

==========
Bug Fix: Cursor Stretched During Tab Capturing On Windows

On Windows 10, the mouse cursor is vertically stretched during
screen capturing. 

This CL fixes the bug.

BUG=655198
==========

to

==========
Bug Fix: Cursor Stretched During Tab Capturing On Windows

On Windows 10, the mouse cursor is vertically stretched during
screen capturing. 

This CL fixes the bug.

BUG=655198
==========

[commit-bot: I haz the power, 2016-10-20 20:55:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:22:17]

Description was changed from

==========
Bug Fix: Cursor Stretched During Tab Capturing On Windows

On Windows 10, the mouse cursor is vertically stretched during
screen capturing. 

This CL fixes the bug.

BUG=655198
==========

to

==========
Bug Fix: Cursor Stretched During Tab Capturing On Windows

On Windows 10, the mouse cursor is vertically stretched during
screen capturing.

This CL fixes the bug.

BUG=655198

Committed: https://crrev.com/b5f188496d88bbef4ec99ee84742f61380f8516e
Cr-Commit-Position: refs/heads/master@{#426589}
==========

[commit-bot: I haz the power, 2016-10-21 13:22:17]

Patchset 2 (id:??) landed as
https://crrev.com/b5f188496d88bbef4ec99ee84742f61380f8516e
Cr-Commit-Position: refs/heads/master@{#426589}