Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 2423193003: [NTP Snippets] Add UMA for database load time (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add UMA for database load time BUG=645070 Committed: https://crrev.com/4a711318f9b8f69695797de99147c6dbefe6062b Cr-Commit-Position: refs/heads/master@{#426163}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M components/ntp_snippets/remote/ntp_snippets_service.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippets_service.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Marc Treib
PTAL!
4 years, 2 months ago (2016-10-18 14:55:43 UTC) #2
Michael van Ouwerkerk
lgtm
4 years, 2 months ago (2016-10-18 15:04:32 UTC) #5
Marc Treib
+rkaplow for histograms.xml, PTAL! https://codereview.chromium.org/2423193003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2423193003/diff/1/tools/metrics/histograms/histograms.xml#newcode37802 tools/metrics/histograms/histograms.xml:37802: +<histogram name="NewTabPage.Snippets.DatabaseLoadTime"> Is there a ...
4 years, 2 months ago (2016-10-18 15:07:48 UTC) #7
rkaplow
lgtm https://codereview.chromium.org/2423193003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2423193003/diff/1/tools/metrics/histograms/histograms.xml#newcode37802 tools/metrics/histograms/histograms.xml:37802: +<histogram name="NewTabPage.Snippets.DatabaseLoadTime"> On 2016/10/18 15:07:48, Marc Treib wrote: ...
4 years, 2 months ago (2016-10-18 20:24:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423193003/20001
4 years, 2 months ago (2016-10-19 09:30:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/319432)
4 years, 2 months ago (2016-10-19 11:13:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423193003/20001
4 years, 2 months ago (2016-10-19 11:27:26 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 12:48:54 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:07:29 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a711318f9b8f69695797de99147c6dbefe6062b
Cr-Commit-Position: refs/heads/master@{#426163}

Powered by Google App Engine
This is Rietveld 408576698