Delete fullscreen/mouselock pref data associated with extensions.

Delete fullscreen/mouselock pref data associated with extensions.

This deletes all data associated with the now-removed
chrome.contentSettings.{fullscreen,mouselock} APIs, on startup. Despite
those APIs having been removed in M55 (r422716), the data (fullscreen
and mouselock exception rules associated per-extension per-site) would
still be stored. This deletes the data, as it is no longer being used.

BUG=591896
Committed: https://crrev.com/8550142e5c20a86576d98de3a4d7031592bc9692
Cr-Commit-Position: refs/heads/master@{#426737}

[Matt Giuca, 2016-10-21 05:00:19]

mgiuca@chromium.org changed reviewers:
+ benwells@chromium.org

[benwells, 2016-10-21 05:19:04]

lgtm

https://codereview.chromium.org/2423003002/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc
(right):

https://codereview.chromium.org/2423003002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc:330:
// Fullscreen and mouselock should remain unchanged.
Nit: Would it be clearer to say "not be stored" instead of "remain unchanged"?

[Matt Giuca, 2016-10-21 05:21:43]

https://codereview.chromium.org/2423003002/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc
(right):

https://codereview.chromium.org/2423003002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc:330:
// Fullscreen and mouselock should remain unchanged.
On 2016/10/21 05:19:04, benwells (slow) wrote:
> Nit: Would it be clearer to say "not be stored" instead of "remain unchanged"?

This getter isn't directly getting the data that we just put in above. It's
doing an aggregated query over all extensions, so we're really testing that the
result hasn't changed from the default (versus explicitly testing what is
stored).

Regardless, I have a CL lined up that's going to delete this check anyway (when
FULLSCREEN and MOUSELOCK are removed from the enum).

[Matt Giuca, 2016-10-21 05:31:32]

https://codereview.chromium.org/2423003002/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc
(right):

https://codereview.chromium.org/2423003002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc:330:
// Fullscreen and mouselock should remain unchanged.
On 2016/10/21 05:21:43, Matt Giuca wrote:
> On 2016/10/21 05:19:04, benwells (slow) wrote:
> > Nit: Would it be clearer to say "not be stored" instead of "remain
unchanged"?
> 
> This getter isn't directly getting the data that we just put in above. It's
> doing an aggregated query over all extensions, so we're really testing that
the
> result hasn't changed from the default (versus explicitly testing what is
> stored).
> 
> Regardless, I have a CL lined up that's going to delete this check anyway
(when
> FULLSCREEN and MOUSELOCK are removed from the enum).

Done.

[Matt Giuca, 2016-10-21 05:31:37]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-10-21 05:31:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2423003002/#ps60001
(title: "Fix confusing wording.")

[commit-bot: I haz the power, 2016-10-21 05:31:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 06:34:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:27:44]

Description was changed from

==========
Delete fullscreen/mouselock pref data associated with extensions.

This deletes all data associated with the now-removed
chrome.contentSettings.{fullscreen,mouselock} APIs, on startup. Despite
those APIs having been removed in M55 (r422716), the data (fullscreen
and mouselock exception rules associated per-extension per-site) would
still be stored. This deletes the data, as it is no longer being used.

BUG=591896
==========

to

==========
Delete fullscreen/mouselock pref data associated with extensions.

This deletes all data associated with the now-removed
chrome.contentSettings.{fullscreen,mouselock} APIs, on startup. Despite
those APIs having been removed in M55 (r422716), the data (fullscreen
and mouselock exception rules associated per-extension per-site) would
still be stored. This deletes the data, as it is no longer being used.

BUG=591896

Committed: https://crrev.com/8550142e5c20a86576d98de3a4d7031592bc9692
Cr-Commit-Position: refs/heads/master@{#426737}
==========

[commit-bot: I haz the power, 2016-10-21 13:27:45]

Patchset 4 (id:??) landed as
https://crrev.com/8550142e5c20a86576d98de3a4d7031592bc9692
Cr-Commit-Position: refs/heads/master@{#426737}