Repeating header groups should align properly when captions are present

Repeating header groups should align properly when captions are present

BUG=652792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/42151f9c0132a60a7be3b1793295a1966f532ca6
Cr-Commit-Position: refs/heads/master@{#426243}

[rhogan, 2016-10-17 10:53:00]

Description was changed from

==========
Repeating header groups should align properly when captions are present
BUG=652792
==========

to

==========
Repeating header groups should align properly when captions are present
BUG=652792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-10-17 10:53:06]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 10:53:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 12:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 12:17:13]

Dry run: This issue passed the CQ dry run.

[rhogan, 2016-10-17 12:22:21]

robhogan@gmail.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2016-10-17 19:21:13]

Need a blank line before the BUG= line in the commit comment.

https://codereview.chromium.org/2422953003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTable.cpp (right):

https://codereview.chromium.org/2422953003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTable.cpp:1476: if
(caption->style()->captionSide() == ECaptionSide::Top)
There may be more than one top caption.

https://codereview.chromium.org/2422953003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):

https://codereview.chromium.org/2422953003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:76:
paginationOffset.move(0, -table->topCaption()->logicalHeight().toInt());
So, it's possible to have as many top captions as you want, so this seems wrong.
How about subtracting the logical top of the section instead?

[rhogan, 2016-10-18 16:02:21]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 16:02:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-10-18 16:02:46]

https://codereview.chromium.org/2422953003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):

https://codereview.chromium.org/2422953003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:76:
paginationOffset.move(0, -table->topCaption()->logicalHeight().toInt());
On 2016/10/17 at 19:21:13, mstensho wrote:
> So, it's possible to have as many top captions as you want, so this seems
wrong. How about subtracting the logical top of the section instead?

Indeed, thanks - updated!

[mstensho (USE GERRIT), 2016-10-18 17:08:49]

lgtm, but the commit message still needs to be fixed.

https://codereview.chromium.org/2422953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):

https://codereview.chromium.org/2422953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:74:
paginationOffset.move(0, -m_layoutTableSection.logicalTop().toInt());
LayoutUnit() is cheaper than 0.

[commit-bot: I haz the power, 2016-10-18 17:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:26:48]

Dry run: This issue passed the CQ dry run.

[rhogan, 2016-10-19 09:25:40]

Description was changed from

==========
Repeating header groups should align properly when captions are present
BUG=652792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Repeating header groups should align properly when captions are present

BUG=652792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-10-19 16:33:18]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-10-19 16:33:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2422953003/#ps40001
(title: "Repeating header groups should align properly when captions are present
BUG=652792 CQ_INCLUDE_TRYBO…")

[commit-bot: I haz the power, 2016-10-19 16:34:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 18:08:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:10:07]

Description was changed from

==========
Repeating header groups should align properly when captions are present

BUG=652792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Repeating header groups should align properly when captions are present

BUG=652792
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/42151f9c0132a60a7be3b1793295a1966f532ca6
Cr-Commit-Position: refs/heads/master@{#426243}
==========

[commit-bot: I haz the power, 2016-10-21 13:10:08]

Patchset 3 (id:??) landed as
https://crrev.com/42151f9c0132a60a7be3b1793295a1966f532ca6
Cr-Commit-Position: refs/heads/master@{#426243}