Add serializers for window.performance.

Add serializers for
 - window.performance
 - window.performance.navigation
 - window.performance.memory

BUG=651797
Committed: https://crrev.com/fb6c988e174e59fed729751deabe71fbb470b1a3
Cr-Commit-Position: refs/heads/master@{#426231}

[martijnc, 2016-10-16 19:40:33]

Patchset #2 (id:20001) has been deleted

[martijnc, 2016-10-16 20:30:17]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-10-16 21:20:04]

Patchset #2 (id:60001) has been deleted

[martijnc, 2016-10-16 21:20:55]

Patchset #1 (id:40001) has been deleted

[martijnc, 2016-10-16 21:22:08]

Description was changed from

==========
Add serializers for window.performance and window.performance.navigation.

BUG=651797
==========

to

==========
Add serializers for
 - window.performance
 - window.performance.navigation
 - window.performance.memory

BUG=651797
==========

[martijnc, 2016-10-16 21:31:01]

martijn@martijnc.be changed reviewers:
+ foolip@chromium.org

[martijnc, 2016-10-17 15:40:12]

Hi, can you review this patch?

Thanks!

https://codereview.chromium.org/2422913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2422913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:108: result.add("memory",
memory()->toJSONForBinding(scriptState));
Would it be better to ignore performance.memory for the serialization because it
is a non-standard API?

[foolip, 2016-10-18 10:27:59]

foolip@chromium.org changed reviewers:
+ igrigorik@chromium.org

[foolip, 2016-10-18 10:28:00]

igrigorik@, any thoughts on the likely fate of performance.memory?
https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5YRCGpC9vs/b4OJz71N...
is the last discussion I think.

https://codereview.chromium.org/2422913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/2422913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/Performance.cpp:108: result.add("memory",
memory()->toJSONForBinding(scriptState));
On 2016/10/17 15:40:12, martijnc wrote:
> Would it be better to ignore performance.memory for the serialization because
it
> is a non-standard API?

Good question. I think it depends on what we hope will happen to
performance.memory. If it's plausibly on a track to be implemented elsewhere,
then keeping it out here doesn't seem useful, but if we want to get rid of it
then spreading it around can make it *very slightly* harder to remove.

Will add Ilya.

[igrigorik, 2016-10-18 16:22:40]

On 2016/10/18 10:28:00, foolip wrote:
> igrigorik@, any thoughts on the likely fate of performance.memory?
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5YRCGpC9vs/b4OJz71N...
> is the last discussion I think.

Latest is: https://github.com/w3c/charter-webperf/issues/33

> > Would it be better to ignore performance.memory for the serialization
because
> > it is a non-standard API?
> 
> Good question. I think it depends on what we hope will happen to
> performance.memory. If it's plausibly on a track to be implemented elsewhere,
> then keeping it out here doesn't seem useful, but if we want to get rid of it
> then spreading it around can make it *very slightly* harder to remove.

I'd skip it, our goal is (still) to remove and replace it with something more
useful and supported by multiple browsers.

[martijnc, 2016-10-18 18:59:54]

Patchset #2 (id:100001) has been deleted

[martijnc, 2016-10-18 20:29:32]

Thank you for the feedback. I uploaded PS2 which removes the performance.memory
serialization.

[foolip, 2016-10-19 14:23:39]

lgtm

[martijnc, 2016-10-19 15:49:59]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2016-10-19 15:50:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 17:21:03]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-10-21 13:09:40]

Description was changed from

==========
Add serializers for
 - window.performance
 - window.performance.navigation
 - window.performance.memory

BUG=651797
==========

to

==========
Add serializers for
 - window.performance
 - window.performance.navigation
 - window.performance.memory

BUG=651797

Committed: https://crrev.com/fb6c988e174e59fed729751deabe71fbb470b1a3
Cr-Commit-Position: refs/heads/master@{#426231}
==========

[commit-bot: I haz the power, 2016-10-21 13:09:41]

Patchset 2 (id:??) landed as
https://crrev.com/fb6c988e174e59fed729751deabe71fbb470b1a3
Cr-Commit-Position: refs/heads/master@{#426231}