Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2105)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java

Issue 24228003: Upstream ShouldOverrideUrlLoading changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed a non-related line to keep chrome bots happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
index 5d0e5ce40c3a7272a10ff1053c62d2e13453b544..0e1555546c3b3d8f63028e49f506a8f0bb5bd6f0 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
@@ -395,6 +395,32 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
shouldOverrideUrlLoadingHelper.waitForCallback(callCount);
}
+ @SmallTest
+ @Feature({"AndroidWebView", "Navigation"})
+ public void testCalledWhenTopLevelAboutBlankNavigation() throws Throwable {
+ final TestAwContentsClient contentsClient = new TestAwContentsClient();
+ final AwTestContainerView testContainerView =
+ createAwTestContainerViewOnMainSync(contentsClient);
+ final AwContents awContents = testContainerView.getAwContents();
+ TestAwContentsClient.ShouldOverrideUrlLoadingHelper shouldOverrideUrlLoadingHelper =
+ contentsClient.getShouldOverrideUrlLoadingHelper();
+
+ final String httpPath = "/page_with_about_blank_navigation";
+ final String httpPathOnServer = mWebServer.getResponseUrl(httpPath);
+ addPageToTestServer(mWebServer, httpPath,
+ getHtmlForPageWithSimpleLinkTo(ABOUT_BLANK_URL));
+
+ loadUrlSync(awContents, contentsClient.getOnPageFinishedHelper(),
+ httpPathOnServer);
+
+ int callCount = shouldOverrideUrlLoadingHelper.getCallCount();
+
+ clickOnLinkUsingJs(awContents, contentsClient);
+
+ shouldOverrideUrlLoadingHelper.waitForCallback(callCount);
+ assertEquals(ABOUT_BLANK_URL,
+ shouldOverrideUrlLoadingHelper.getShouldOverrideUrlLoadingUrl());
+ }
@SmallTest
@Feature({"AndroidWebView", "Navigation"})

Powered by Google App Engine
This is Rietveld 408576698