Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 24225002: Don't dispatch events when XHR is set to sync mode (Closed)

Created:
7 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't dispatch events when XHR is set to sync mode Any of readystatechange, progress, abort, error, timeout and loadend event are not specified to be dispatched in sync mode in the latest spec. Just an exception corresponding to the failure is thrown. Clean up for readability done in this CL - factor out dispatchEventAndLoadEnd calling code - make didTimeout() private - give error handling methods more descriptive names - set m_exceptionCode in failure type specific methods -- Note that for didFailRedirectCheck, m_exceptionCode was not set in networkError(), but was set at the end of createRequest() This CL is prep for fixing crbug.com/292422 BUG=292422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158046

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Updated layout tests #

Patch Set 4 : Put back internalAbort() #

Patch Set 5 : Put back internalAbort() 2 #

Patch Set 6 : Revert change on network-preflight-options.html #

Messages

Total messages: 5 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 3 months ago (2013-09-18 17:51:18 UTC) #1
tyoshino (SeeGerritForStatus)
internalAbort() was removed from handleNetworkError() by mistake. Put it back.
7 years, 3 months ago (2013-09-19 10:01:58 UTC) #2
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-19 18:28:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/24225002/20001
7 years, 3 months ago (2013-09-19 18:28:58 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 19:46:44 UTC) #5
Message was sent while issue was closed.
Change committed as 158046

Powered by Google App Engine
This is Rietveld 408576698