Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2422413003: customtabs: Add a histogram about the state if the renderer on creation. (Closed)

Created:
4 years, 2 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
Yusuf, Ilya Sherman
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Add a histogram about the state if the renderer on creation. This adds an histogram giving the breakdown between the different types of WebContents state on tab creation (prerender, spare renderer or none). BUG=633964 Committed: https://crrev.com/d9eaf67b1505d1bc103d3c9021f5a4b6545457b1 Cr-Commit-Position: refs/heads/master@{#426568}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Benoit L
4 years, 2 months ago (2016-10-18 20:42:48 UTC) #2
Benoit L
4 years, 2 months ago (2016-10-18 20:43:16 UTC) #4
Ilya Sherman
lgtm % a nit: https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode83 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:83: private static final int WEBCONTENTS_STATE_MAX ...
4 years, 2 months ago (2016-10-18 21:12:08 UTC) #5
Yusuf
lgtm
4 years, 2 months ago (2016-10-19 18:44:06 UTC) #6
Benoit L
Thanks! https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode83 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:83: private static final int WEBCONTENTS_STATE_MAX = 3; On ...
4 years, 2 months ago (2016-10-20 18:15:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422413003/40001
4 years, 2 months ago (2016-10-20 18:15:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-20 19:48:16 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:31 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d9eaf67b1505d1bc103d3c9021f5a4b6545457b1
Cr-Commit-Position: refs/heads/master@{#426568}

Powered by Google App Engine
This is Rietveld 408576698