customtabs: Add a histogram about the state if the renderer on creation.

customtabs: Add a histogram about the state if the renderer on creation.

This adds an histogram giving the breakdown between the different types
of WebContents state on tab creation (prerender, spare renderer or none).

BUG=633964
Committed: https://crrev.com/d9eaf67b1505d1bc103d3c9021f5a4b6545457b1
Cr-Commit-Position: refs/heads/master@{#426568}

[Benoit L, 2016-10-18 20:42:48]

lizeb@chromium.org changed reviewers:
+ isherman@chromium.org, yusufo@google.com

[Benoit L, 2016-10-18 20:43:16]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org
- yusufo@google.com

[Ilya Sherman, 2016-10-18 21:12:08]

lgtm % a nit:

https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:83:
private static final int WEBCONTENTS_STATE_MAX = 3;
Please document that these are used to back an UMA histogram, and hence should
be treated as append-only.

[Yusuf, 2016-10-19 18:44:06]

lgtm

[Benoit L, 2016-10-20 18:15:21]

Thanks!

https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/2422413003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:83:
private static final int WEBCONTENTS_STATE_MAX = 3;
On 2016/10/18 21:12:08, Ilya Sherman wrote:
> Please document that these are used to back an UMA histogram, and hence should
> be treated as append-only.

Done.

[Benoit L, 2016-10-20 18:15:24]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-10-20 18:15:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2422413003/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-10-20 18:15:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:48:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:21:30]

Description was changed from

==========
customtabs: Add a histogram about the state if the renderer on creation.

This adds an histogram giving the breakdown between the different types
of WebContents state on tab creation (prerender, spare renderer or none).

BUG=633964
==========

to

==========
customtabs: Add a histogram about the state if the renderer on creation.

This adds an histogram giving the breakdown between the different types
of WebContents state on tab creation (prerender, spare renderer or none).

BUG=633964

Committed: https://crrev.com/d9eaf67b1505d1bc103d3c9021f5a4b6545457b1
Cr-Commit-Position: refs/heads/master@{#426568}
==========

[commit-bot: I haz the power, 2016-10-21 13:21:31]

Patchset 3 (id:??) landed as
https://crrev.com/d9eaf67b1505d1bc103d3c9021f5a4b6545457b1
Cr-Commit-Position: refs/heads/master@{#426568}