Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4608)

Unified Diff: chrome/test/chromedriver/run_buildbot_steps.py

Issue 24224006: [chromedriver] Fixes for android tests gating chromedriver release. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed frankf's comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/buildbot/bb_device_steps.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/run_buildbot_steps.py
diff --git a/chrome/test/chromedriver/run_buildbot_steps.py b/chrome/test/chromedriver/run_buildbot_steps.py
index ddc05fdc5cd71ae364c9d24a8f858f0a4d70583a..ca8798502b8679127fabd4623bfe9ce1d324a8b7 100755
--- a/chrome/test/chromedriver/run_buildbot_steps.py
+++ b/chrome/test/chromedriver/run_buildbot_steps.py
@@ -391,8 +391,9 @@ def main():
help='Comma separated list of application package names, '
'if running tests on Android.')
parser.add_option(
- '-r', '--revision', type='int', default=None,
- help='Chromium revision')
+ '-r', '--revision', type='int', help='Chromium revision')
+ parser.add_option('', '--update-log', action='store_true',
+ help='Update the test results log (only applicable to Android)')
options, _ = parser.parse_args()
bitness = '32'
@@ -407,11 +408,12 @@ def main():
CleanTmpDir()
if platform == 'android':
+ if not options.revision and options.update_log:
+ parser.error('Must supply a --revision with --update-log')
DownloadPrebuilts()
else:
if not options.revision:
parser.error('Must supply a --revision')
-
if platform == 'linux64':
ArchivePrebuilts(options.revision)
@@ -427,7 +429,8 @@ def main():
passed = (util.RunCommand(cmd) == 0)
if platform == 'android':
- UpdateTestResultsLog(platform, options.revision, passed)
+ if options.update_log:
+ UpdateTestResultsLog(platform, options.revision, passed)
elif passed:
_MaybeUpdateReleaseCandidate(platform, options.revision)
_MaybeRelease(platform)
« no previous file with comments | « build/android/buildbot/bb_device_steps.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698