Issue 24224006: [chromedriver] Fixes for android tests gating chromedriver release.

Issue 24224006: [chromedriver] Fixes for android tests gating chromedriver release. (Closed)

Created:
7 years, 3 months ago by craigdh

Modified:
7 years, 3 months ago

Reviewers:
navabi1, Isaac (away), navabi, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, kkania, frankf, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Fixes for android tests gating chromedriver release. Previously the revision was not passed. Also fixes a bug where downstream would have also updated the android test results log. BUG=None TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224410

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : addressed frankf's comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		3 chunks	+20 lines, -5 lines	0 comments	Download
	M	chrome/test/chromedriver/run_buildbot_steps.py	View	1 2	3 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm https://codereview.chromium.org/24224006/diff/3001/chrome/test/chromedriver/run_buildbot_steps.py File chrome/test/chromedriver/run_buildbot_steps.py (right): https://codereview.chromium.org/24224006/diff/3001/chrome/test/chromedriver/run_buildbot_steps.py#newcode394 chrome/test/chromedriver/run_buildbot_steps.py:394: '-r', '--revision', type='int', default=None, help='Chromium revision') default is ...

7 years, 3 months ago (2013-09-18 22:51:06 UTC) #2

craigdh

https://codereview.chromium.org/24224006/diff/3001/chrome/test/chromedriver/run_buildbot_steps.py File chrome/test/chromedriver/run_buildbot_steps.py (right): https://codereview.chromium.org/24224006/diff/3001/chrome/test/chromedriver/run_buildbot_steps.py#newcode394 chrome/test/chromedriver/run_buildbot_steps.py:394: '-r', '--revision', type='int', default=None, help='Chromium revision') On 2013/09/18 22:51:07, ...

7 years, 3 months ago (2013-09-18 22:55:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/24224006/9001

7 years, 3 months ago (2013-09-20 17:11:29 UTC) #6

Message was sent while issue was closed.

Change committed as 224410

Expand Messages | Collapse Messages