Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: xfa/fwl/lightwidget/cfwl_pushbutton.cpp

Issue 2422303003: Remove FWL Create methods, use new instead (Closed)
Patch Set: Review fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_pushbutton.h ('k') | xfa/fxfa/app/xfa_ffbarcode.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/lightwidget/cfwl_pushbutton.h" 7 #include "xfa/fwl/lightwidget/cfwl_pushbutton.h"
8 8
9 #include <memory> 9 #include <memory>
10 10
11 IFWL_PushButton* CFWL_PushButton::GetWidget() { 11 IFWL_PushButton* CFWL_PushButton::GetWidget() {
12 return static_cast<IFWL_PushButton*>(m_pIface.get()); 12 return static_cast<IFWL_PushButton*>(m_pIface.get());
13 } 13 }
14 14
15 const IFWL_PushButton* CFWL_PushButton::GetWidget() const { 15 const IFWL_PushButton* CFWL_PushButton::GetWidget() const {
16 return static_cast<IFWL_PushButton*>(m_pIface.get()); 16 return static_cast<IFWL_PushButton*>(m_pIface.get());
17 } 17 }
18 18
19 CFWL_PushButton* CFWL_PushButton::Create() {
20 return new CFWL_PushButton;
21 }
22
23 FWL_Error CFWL_PushButton::Initialize( 19 FWL_Error CFWL_PushButton::Initialize(
24 const CFWL_WidgetProperties* pProperties) { 20 const CFWL_WidgetProperties* pProperties) {
25 if (m_pIface) 21 if (m_pIface)
26 return FWL_Error::Indefinite; 22 return FWL_Error::Indefinite;
27 if (pProperties) { 23 if (pProperties) {
28 *m_pProperties = *pProperties; 24 *m_pProperties = *pProperties;
29 } 25 }
30 std::unique_ptr<IFWL_PushButton> pPushButton(IFWL_PushButton::Create( 26 std::unique_ptr<IFWL_PushButton> pPushButton(IFWL_PushButton::Create(
31 m_pProperties->MakeWidgetImpProperties(&m_buttonData), nullptr)); 27 m_pProperties->MakeWidgetImpProperties(&m_buttonData), nullptr));
32 FWL_Error ret = pPushButton->Initialize(); 28 FWL_Error ret = pPushButton->Initialize();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 IFWL_Widget* pWidget, 61 IFWL_Widget* pWidget,
66 CFX_WideString& wsCaption) { 62 CFX_WideString& wsCaption) {
67 wsCaption = m_wsCaption; 63 wsCaption = m_wsCaption;
68 return FWL_Error::Succeeded; 64 return FWL_Error::Succeeded;
69 } 65 }
70 66
71 CFX_DIBitmap* CFWL_PushButton::CFWL_PushButtonDP::GetPicture( 67 CFX_DIBitmap* CFWL_PushButton::CFWL_PushButtonDP::GetPicture(
72 IFWL_Widget* pWidget) { 68 IFWL_Widget* pWidget) {
73 return m_pBitmap; 69 return m_pBitmap;
74 } 70 }
OLDNEW
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_pushbutton.h ('k') | xfa/fxfa/app/xfa_ffbarcode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698