Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: xfa/fwl/lightwidget/cfwl_edit.cpp

Issue 2422303003: Remove FWL Create methods, use new instead (Closed)
Patch Set: Review fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_edit.h ('k') | xfa/fwl/lightwidget/cfwl_listbox.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/lightwidget/cfwl_edit.h" 7 #include "xfa/fwl/lightwidget/cfwl_edit.h"
8 8
9 #include <memory> 9 #include <memory>
10 #include <vector> 10 #include <vector>
11 11
12 IFWL_Edit* CFWL_Edit::GetWidget() { 12 IFWL_Edit* CFWL_Edit::GetWidget() {
13 return static_cast<IFWL_Edit*>(m_pIface.get()); 13 return static_cast<IFWL_Edit*>(m_pIface.get());
14 } 14 }
15 15
16 const IFWL_Edit* CFWL_Edit::GetWidget() const { 16 const IFWL_Edit* CFWL_Edit::GetWidget() const {
17 return static_cast<IFWL_Edit*>(m_pIface.get()); 17 return static_cast<IFWL_Edit*>(m_pIface.get());
18 } 18 }
19 19
20 CFWL_Edit* CFWL_Edit::Create() {
21 return new CFWL_Edit;
22 }
23
24 FWL_Error CFWL_Edit::Initialize(const CFWL_WidgetProperties* pProperties) { 20 FWL_Error CFWL_Edit::Initialize(const CFWL_WidgetProperties* pProperties) {
25 if (m_pIface) 21 if (m_pIface)
26 return FWL_Error::Indefinite; 22 return FWL_Error::Indefinite;
27 if (pProperties) { 23 if (pProperties) {
28 *m_pProperties = *pProperties; 24 *m_pProperties = *pProperties;
29 } 25 }
30 std::unique_ptr<IFWL_Edit> pEdit(IFWL_Edit::Create( 26 std::unique_ptr<IFWL_Edit> pEdit(IFWL_Edit::Create(
31 m_pProperties->MakeWidgetImpProperties(nullptr), nullptr)); 27 m_pProperties->MakeWidgetImpProperties(nullptr), nullptr));
32 FWL_Error ret = pEdit->Initialize(); 28 FWL_Error ret = pEdit->Initialize();
33 if (ret != FWL_Error::Succeeded) { 29 if (ret != FWL_Error::Succeeded) {
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 } 231 }
236 232
237 FX_BOOL CFWL_Edit::ReplaceSpellCheckWord(CFX_PointF pointf, 233 FX_BOOL CFWL_Edit::ReplaceSpellCheckWord(CFX_PointF pointf,
238 const CFX_ByteStringC& bsReplace) { 234 const CFX_ByteStringC& bsReplace) {
239 return GetWidget()->ReplaceSpellCheckWord(pointf, bsReplace); 235 return GetWidget()->ReplaceSpellCheckWord(pointf, bsReplace);
240 } 236 }
241 237
242 CFWL_Edit::CFWL_Edit() {} 238 CFWL_Edit::CFWL_Edit() {}
243 239
244 CFWL_Edit::~CFWL_Edit() {} 240 CFWL_Edit::~CFWL_Edit() {}
OLDNEW
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_edit.h ('k') | xfa/fwl/lightwidget/cfwl_listbox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698