Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: xfa/fwl/lightwidget/cfwl_combobox.h

Issue 2422303003: Remove FWL Create methods, use new instead (Closed)
Patch Set: Review fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_checkbox.cpp ('k') | xfa/fwl/lightwidget/cfwl_combobox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef XFA_FWL_LIGHTWIDGET_CFWL_COMBOBOX_H_ 7 #ifndef XFA_FWL_LIGHTWIDGET_CFWL_COMBOBOX_H_
8 #define XFA_FWL_LIGHTWIDGET_CFWL_COMBOBOX_H_ 8 #define XFA_FWL_LIGHTWIDGET_CFWL_COMBOBOX_H_
9 9
10 #include <memory> 10 #include <memory>
11 #include <vector> 11 #include <vector>
12 12
13 #include "xfa/fwl/basewidget/ifwl_combobox.h" 13 #include "xfa/fwl/basewidget/ifwl_combobox.h"
14 #include "xfa/fwl/lightwidget/cfwl_widget.h" 14 #include "xfa/fwl/lightwidget/cfwl_widget.h"
15 15
16 class CFWL_WidgetProperties; 16 class CFWL_WidgetProperties;
17 class IFWL_ComboBoxDP; 17 class IFWL_ComboBoxDP;
18 class CFWL_ComboBoxDP; 18 class CFWL_ComboBoxDP;
19 class CFWL_ComboBoxItem; 19 class CFWL_ComboBoxItem;
20 20
21 class CFWL_ComboBox : public CFWL_Widget { 21 class CFWL_ComboBox : public CFWL_Widget {
22 public: 22 public:
23 CFWL_ComboBox(); 23 CFWL_ComboBox();
24 ~CFWL_ComboBox() override; 24 ~CFWL_ComboBox() override;
25 25
26 IFWL_ComboBox* GetWidget() override; 26 IFWL_ComboBox* GetWidget() override;
27 const IFWL_ComboBox* GetWidget() const override; 27 const IFWL_ComboBox* GetWidget() const override;
28 28
29 static CFWL_ComboBox* Create();
30 FWL_Error Initialize(const CFWL_WidgetProperties* pProperties = nullptr); 29 FWL_Error Initialize(const CFWL_WidgetProperties* pProperties = nullptr);
31 int32_t AddString(const CFX_WideStringC& wsText); 30 int32_t AddString(const CFX_WideStringC& wsText);
32 int32_t AddString(const CFX_WideStringC& wsText, CFX_DIBitmap* pIcon); 31 int32_t AddString(const CFX_WideStringC& wsText, CFX_DIBitmap* pIcon);
33 bool RemoveAt(int32_t iIndex); // Returns false iff |iIndex| out of range. 32 bool RemoveAt(int32_t iIndex); // Returns false iff |iIndex| out of range.
34 void RemoveAll(); 33 void RemoveAll();
35 int32_t CountItems(); 34 int32_t CountItems();
36 FWL_Error GetTextByIndex(int32_t iIndex, CFX_WideString& wsText); 35 FWL_Error GetTextByIndex(int32_t iIndex, CFX_WideString& wsText);
37 int32_t GetCurSel(); 36 int32_t GetCurSel();
38 FWL_Error SetCurSel(int32_t iSel); 37 FWL_Error SetCurSel(int32_t iSel);
39 FWL_Error SetEditText(const CFX_WideString& wsText); 38 FWL_Error SetEditText(const CFX_WideString& wsText);
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 CFX_RectF m_rtItem; 139 CFX_RectF m_rtItem;
141 uint32_t m_dwStyles; 140 uint32_t m_dwStyles;
142 CFX_WideString m_wsText; 141 CFX_WideString m_wsText;
143 CFX_DIBitmap* m_pDIB; 142 CFX_DIBitmap* m_pDIB;
144 uint32_t m_dwCheckState; 143 uint32_t m_dwCheckState;
145 CFX_RectF m_rtCheckBox; 144 CFX_RectF m_rtCheckBox;
146 void* m_pData; 145 void* m_pData;
147 }; 146 };
148 147
149 #endif // XFA_FWL_LIGHTWIDGET_CFWL_COMBOBOX_H_ 148 #endif // XFA_FWL_LIGHTWIDGET_CFWL_COMBOBOX_H_
OLDNEW
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_checkbox.cpp ('k') | xfa/fwl/lightwidget/cfwl_combobox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698