Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2422233004: [MD settings] name Content settings separately from site settings (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] name Content settings separately from site settings This CL puts the 'site settings' name behind the enable-site-settings flag. When site settings is disabled, the name 'content settings' is used. BUG=654940 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c5b4ee3f84b2765fc91ef58fb14af3384cafe729 Cr-Commit-Position: refs/heads/master@{#426013}

Patch Set 1 : comment changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dschuyler
4 years, 2 months ago (2016-10-18 00:19:55 UTC) #8
Dan Beam
lgtm
4 years, 2 months ago (2016-10-18 00:41:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422233004/20001
4 years, 2 months ago (2016-10-18 18:47:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-18 18:55:11 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:01:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5b4ee3f84b2765fc91ef58fb14af3384cafe729
Cr-Commit-Position: refs/heads/master@{#426013}

Powered by Google App Engine
This is Rietveld 408576698