Web MIDI: use midi_service.mojom for media::midi::PortState

Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
TBR=jochen@chromium.org

Committed: https://crrev.com/b6ce16127b0dc25243d30650728461face866d04
Cr-Commit-Position: refs/heads/master@{#426756}

[Takashi Toyoshima, 2016-10-17 11:33:55]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 11:34:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 11:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 11:56:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Takashi Toyoshima, 2016-10-17 12:25:56]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 12:26:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 14:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:03:35]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-10-17 18:32:30]

Description was changed from

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
==========

to

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
==========

[Takashi Toyoshima, 2016-10-17 18:32:31]

toyoshim@chromium.org changed reviewers:
+ reillyg@chromium.org, yhirano@chromium.org

[Takashi Toyoshima (Google), 2016-10-17 18:34:21]

toyoshim@google.com changed reviewers:
+ jochen@chromium.org, tsepez@chromium.org

[Takashi Toyoshima (Google), 2016-10-17 18:38:28]

Hi, can you take a look at this second CL of Web MIDI mojofication?

midi_message_filter.cc contains non-mechanical (but almost trivial) changes.
Other files should have only mechanical changes, and they are modified in the
same way with the first CL.

[Tom Sepez, 2016-10-17 18:39:02]

messages LGTM

[Reilly Grant (use Gerrit), 2016-10-17 19:16:19]

https://codereview.chromium.org/2422163002/diff/20001/content/renderer/media/...
File content/renderer/media/midi_message_filter.cc (right):

https://codereview.chromium.org/2422163002/diff/20001/content/renderer/media/...
content/renderer/media/midi_message_filter.cc:234: // TODO(toyoshim): Pass
through the state as is.
This comment is confusing. Can we keep ToBlinkState for now?

[Takashi Toyoshima, 2016-10-19 07:25:47]

As Reilly suggested, I revert non-mechanical changes that remove ToBlinkState
and add some logics from this CL.

https://codereview.chromium.org/2422163002/diff/20001/content/renderer/media/...
File content/renderer/media/midi_message_filter.cc (right):

https://codereview.chromium.org/2422163002/diff/20001/content/renderer/media/...
content/renderer/media/midi_message_filter.cc:234: // TODO(toyoshim): Pass
through the state as is.
OK, I'd remove non-mechanical changes from this CL.

[Reilly Grant (use Gerrit), 2016-10-19 19:24:18]

lgtm with one nit

https://codereview.chromium.org/2422163002/diff/60001/content/renderer/media/...
File content/renderer/media/midi_message_filter_unittest.cc (right):

https://codereview.chromium.org/2422163002/diff/60001/content/renderer/media/...
content/renderer/media/midi_message_filter_unittest.cc:15: using PortState =
midi::mojom::PortState;
You should be able to just say "using midi::mojom::PortState" here unless
there's a subtlety I'm not noticing.

[Takashi Toyoshima, 2016-10-20 05:31:59]

https://codereview.chromium.org/2422163002/diff/60001/content/renderer/media/...
File content/renderer/media/midi_message_filter_unittest.cc (right):

https://codereview.chromium.org/2422163002/diff/60001/content/renderer/media/...
content/renderer/media/midi_message_filter_unittest.cc:15: using PortState =
midi::mojom::PortState;
Oops, thank you for catching this. Old code made me confused.

[Takashi Toyoshima, 2016-10-20 05:34:49]

I will wait other reviews for
 - components/test_runner/mock_web_midi_accessor.cc by jochen
 - midi by yhirano (optional)

[yhirano, 2016-10-21 02:21:50]

Sorry for the delay. LGTM.

https://codereview.chromium.org/2422163002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp (right):

https://codereview.chromium.org/2422163002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp:48: using PortState =
midi::mojom::PortState;
using midi::mojom::PortState;

[Takashi Toyoshima, 2016-10-21 05:46:56]

https://codereview.chromium.org/2422163002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp (right):

https://codereview.chromium.org/2422163002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp:48: using PortState =
midi::mojom::PortState;
Oops, same error :/
Thank you for catching this.

[Takashi Toyoshima, 2016-10-21 05:57:34]

Description was changed from

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
==========

to

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
TBR=jochen@chromium.org
==========

[Takashi Toyoshima, 2016-10-21 05:59:51]

TBR=jochen is added since test_runner changes are only mechanical things that
are required by mojom changes.

[Takashi Toyoshima, 2016-10-21 06:47:21]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-10-21 06:47:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
reillyg@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2422163002/#ps120001
(title: "[rebase and fix merge conflicts]")

[commit-bot: I haz the power, 2016-10-21 06:47:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 06:53:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 06:53:02]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Takashi Toyoshima, 2016-10-21 07:26:46]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-10-21 07:26:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
reillyg@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2422163002/#ps140001
(title: "gn --check fix")

[commit-bot: I haz the power, 2016-10-21 07:26:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 09:15:53]

Description was changed from

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
TBR=jochen@chromium.org
==========

to

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
TBR=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-10-21 09:15:55]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-10-21 13:28:22]

Description was changed from

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
TBR=jochen@chromium.org
==========

to

==========
Web MIDI: use midi_service.mojom for media::midi::PortState

Provide PortState from midi_service.mojom to be shared
between content and Blink.

BUG=582327
TBR=jochen@chromium.org

Committed: https://crrev.com/b6ce16127b0dc25243d30650728461face866d04
Cr-Commit-Position: refs/heads/master@{#426756}
==========

[commit-bot: I haz the power, 2016-10-21 13:28:24]

Patchset 8 (id:??) landed as
https://crrev.com/b6ce16127b0dc25243d30650728461face866d04
Cr-Commit-Position: refs/heads/master@{#426756}