Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 24220004: [android] Supply the correct activities for beta/stable packages. (Closed)

Created:
7 years, 3 months ago by craigdh
Modified:
7 years, 3 months ago
Reviewers:
frankf
CC:
chromium-reviews, kkania, frankf
Visibility:
Public.

Description

[android] Supply the correct activities for beta/stable packages. BUG=None TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224486

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixes #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/constants.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
craigdh
7 years, 3 months ago (2013-09-19 17:45:27 UTC) #1
frankf
https://codereview.chromium.org/24220004/diff/1/chrome/test/chromedriver/chrome/device_manager.cc File chrome/test/chromedriver/chrome/device_manager.cc (right): https://codereview.chromium.org/24220004/diff/1/chrome/test/chromedriver/chrome/device_manager.cc#newcode62 chrome/test/chromedriver/chrome/device_manager.cc:62: known_activity = package + ".Main"; Why was this incorrect? ...
7 years, 3 months ago (2013-09-19 18:01:10 UTC) #2
craigdh
better?
7 years, 3 months ago (2013-09-19 18:05:34 UTC) #3
frankf
lgtm https://codereview.chromium.org/24220004/diff/6001/chrome/test/chromedriver/chrome/device_manager.cc File chrome/test/chromedriver/chrome/device_manager.cc (right): https://codereview.chromium.org/24220004/diff/6001/chrome/test/chromedriver/chrome/device_manager.cc#newcode52 chrome/test/chromedriver/chrome/device_manager.cc:52: known_activity = package + ".ContentShellActivity"; This is not ...
7 years, 3 months ago (2013-09-19 20:53:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/24220004/12001
7 years, 3 months ago (2013-09-20 20:50:04 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 21:03:19 UTC) #6
Message was sent while issue was closed.
Change committed as 224486

Powered by Google App Engine
This is Rietveld 408576698