Move WebappRegistry warmup to async task.

Move WebappRegistry warmup to async task.

On Android N the constructor results in a StrictMode violation due to
WebappRegistry#openSharedPreferences. Use initialization on demand
holder idiom to avoid synchronization issues.

BUG=656035
Committed: https://crrev.com/f21ab9c1569a73162ed57c7f09dc7d7e1ec80e24
Cr-Commit-Position: refs/heads/master@{#426823}

[Peter Wen, 2016-10-14 16:25:27]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 16:26:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-14 16:26:14]

wnwen@chromium.org changed reviewers:
+ dominickn@chromium.org

[Peter Wen, 2016-10-14 16:26:15]

I don't think the constructor has to be on the main thread, it's just creating a
hash map and initializing the shared pref right?

[commit-bot: I haz the power, 2016-10-14 17:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 17:07:00]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-10-15 00:13:19]

lgtm (omg my patch actually stuck this time)

On 2016/10/14 16:26:15, Peter Wen wrote:
> I don't think the constructor has to be on the main thread, it's just creating
a
> hash map and initializing the shared pref right?

Previously FindBugs gave me an error on the background thread call to
getInstance() because it could initialise the static WebappRegistry instance,
but that should have gone away now that the instance is marked volatile.

[Peter Wen, 2016-10-17 14:49:44]

Description was changed from

==========
Move WebappRegistry warmup to async task.

On Android N the constructor results in a StrictMode violation due to
WebappRegistry#openSharedPreferences.

BUG=656035
==========

to

==========
Move WebappRegistry warmup to async task.

On Android N the constructor results in a StrictMode violation due to
WebappRegistry#openSharedPreferences. Use initialization on demand
holder idiom to avoid synchronization issues.

BUG=656035
==========

[Peter Wen, 2016-10-17 14:51:25]

On 2016/10/15 00:13:19, dominickn wrote:
> lgtm (omg my patch actually stuck this time)
> 
> On 2016/10/14 16:26:15, Peter Wen wrote:
> > I don't think the constructor has to be on the main thread, it's just
creating
> a
> > hash map and initializing the shared pref right?
> 
> Previously FindBugs gave me an error on the background thread call to
> getInstance() because it could initialise the static WebappRegistry instance,
> but that should have gone away now that the instance is marked volatile.

Updated WebappRegistry with Holder idiom to avoid synchronization issues, since
even though the variable was volatile there could still be races that
re-initialize sInstance. Thanks for catching that.

[Peter Wen, 2016-10-17 14:51:29]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 14:51:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-17 14:52:29]

wnwen@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Peter Wen, 2016-10-17 14:52:30]

+dtrainor@ for chrome/android OWNERS.

[commit-bot: I haz the power, 2016-10-17 15:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 15:24:21]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-10-17 23:15:59]

https://codereview.chromium.org/2421833003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
(right):

https://codereview.chromium.org/2421833003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java:82:
* Warm up the WebappRegistry and a specific WebappDataStorage SharedPreferences.
This static
Nit: this method can initialize sInstance now right? Update comment?

https://codereview.chromium.org/2421833003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java:91:
* Warm up the WebappRegistry and all WebappDataStorage SharedPreferences. This
static method
Nit: this method can initialize sInstance now right? Update comment?

[Peter Wen, 2016-10-18 13:12:32]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 13:12:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-18 13:14:16]

Thanks for catching those comments!

https://codereview.chromium.org/2421833003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
(right):

https://codereview.chromium.org/2421833003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java:82:
* Warm up the WebappRegistry and a specific WebappDataStorage SharedPreferences.
This static
On 2016/10/17 23:15:58, dominickn wrote:
> Nit: this method can initialize sInstance now right? Update comment?

Done.

https://codereview.chromium.org/2421833003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java:91:
* Warm up the WebappRegistry and all WebappDataStorage SharedPreferences. This
static method
On 2016/10/17 23:15:58, dominickn wrote:
> Nit: this method can initialize sInstance now right? Update comment?

Done.

[commit-bot: I haz the power, 2016-10-18 13:44:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 13:44:55]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-10-20 21:38:37]

@dtrainor - friendly ping for DeferredStartupHandler.java OWNERS. :)

[David Trainor- moved to gerrit, 2016-10-21 16:05:32]

Sorry about this!  I was at a conference this week and missed the review after. 
lgtm.

[Peter Wen, 2016-10-21 16:21:08]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-10-21 16:21:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2421833003/#ps40001
(title: "Update comments.")

[commit-bot: I haz the power, 2016-10-21 16:21:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-21 16:22:07]

On 2016/10/21 16:05:32, David Trainor wrote:
> Sorry about this!  I was at a conference this week and missed the review
after. 
> lgtm.

No problem, I should've checked calendar first. Thanks for the review! :)

[commit-bot: I haz the power, 2016-10-21 17:16:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 17:36:10]

Description was changed from

==========
Move WebappRegistry warmup to async task.

On Android N the constructor results in a StrictMode violation due to
WebappRegistry#openSharedPreferences. Use initialization on demand
holder idiom to avoid synchronization issues.

BUG=656035
==========

to

==========
Move WebappRegistry warmup to async task.

On Android N the constructor results in a StrictMode violation due to
WebappRegistry#openSharedPreferences. Use initialization on demand
holder idiom to avoid synchronization issues.

BUG=656035

Committed: https://crrev.com/f21ab9c1569a73162ed57c7f09dc7d7e1ec80e24
Cr-Commit-Position: refs/heads/master@{#426823}
==========

[commit-bot: I haz the power, 2016-10-21 17:36:11]

Patchset 3 (id:??) landed as
https://crrev.com/f21ab9c1569a73162ed57c7f09dc7d7e1ec80e24
Cr-Commit-Position: refs/heads/master@{#426823}