Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2421713003: Milo: Pubsub - Trim out pending build states if there are more than 25 per builder (Closed)

Created:
4 years, 2 months ago by Ryan Tseng
Modified:
4 years, 2 months ago
Reviewers:
estaab, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Pubsub - Trim out pending build states if there are more than 25 per builder BUG=655863 Committed: https://github.com/luci/luci-go/commit/39c1f5c6da051287a0e84f27c6f611181fecb925

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M milo/appengine/buildbot/pubsub.go View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (8 generated)
hinoka
Running as tainted in milo now. In theory this isn't needed after the buildbot side ...
4 years, 2 months ago (2016-10-14 03:31:45 UTC) #4
hinoka
ptal
4 years, 2 months ago (2016-10-17 22:11:12 UTC) #8
estaab
https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pubsub.go File milo/appengine/buildbot/pubsub.go (right): https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pubsub.go#newcode78 milo/appengine/buildbot/pubsub.go:78: // Trim pending build states. These things are large ...
4 years, 2 months ago (2016-10-19 22:09:36 UTC) #9
hinoka
https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pubsub.go File milo/appengine/buildbot/pubsub.go (right): https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pubsub.go#newcode78 milo/appengine/buildbot/pubsub.go:78: // Trim pending build states. These things are large ...
4 years, 2 months ago (2016-10-19 22:23:11 UTC) #10
estaab
lgtm Oh ok, that's perfect. :)
4 years, 2 months ago (2016-10-19 22:26:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421713003/1
4 years, 2 months ago (2016-10-19 22:27:35 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-19 22:39:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/39c1f5c6da051287a0e84f27c6f611181fecb925

Powered by Google App Engine
This is Rietveld 408576698