Milo: Pubsub - Trim out pending build states if there are more than 25 per builder

Milo: Pubsub - Trim out pending build states if there are more than 25 per builder

BUG=655863
Committed: https://github.com/luci/luci-go/commit/39c1f5c6da051287a0e84f27c6f611181fecb925

[Ryan Tseng, 2016-10-14 03:29:20]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 03:29:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-10-14 03:31:44]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org, martiniss@chromium.org

[hinoka, 2016-10-14 03:31:45]

Running as tainted in milo now.  In theory this isn't needed after the buildbot
side change rolls out, but it's probably a good failsafe anyways.

After this change, chromium.fyi runs at around 700KB after gzip, which is still
kind of close to the ceiling, but to trim it down further requires cleaning up
unused things in the pending build state.

[commit-bot: I haz the power, 2016-10-14 03:37:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 03:37:17]

Dry run: This issue passed the CQ dry run.

[hinoka, 2016-10-17 22:11:11]

hinoka@chromium.org changed reviewers:
+ estaab@chromium.org
- martiniss@chromium.org

[hinoka, 2016-10-17 22:11:12]

ptal

[estaab, 2016-10-19 22:09:36]

https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pub...
File milo/appengine/buildbot/pubsub.go (right):

https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pub...
milo/appengine/buildbot/pubsub.go:78: // Trim pending build states.  These
things are large and we can't really
How can we inform consumers that this was trimmed? We really need to do that.

[hinoka, 2016-10-19 22:23:11]

https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pub...
File milo/appengine/buildbot/pubsub.go (right):

https://codereview.chromium.org/2421713003/diff/1/milo/appengine/buildbot/pub...
milo/appengine/buildbot/pubsub.go:78: // Trim pending build states.  These
things are large and we can't really
On 2016/10/19 22:09:35, estaab wrote:
> How can we inform consumers that this was trimmed? We really need to do that.

We send both the total number of pending builds (int) and details about the
first 25, so it would show up as something like

Pending Builds (100):
* detail...
* detail...
...23 more...

[estaab, 2016-10-19 22:26:56]

lgtm

Oh ok, that's perfect. :)

[hinoka, 2016-10-19 22:27:25]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:27:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:39:41]

Description was changed from

==========
Milo: Pubsub - Trim out pending build states if there are more than 25 per
builder

BUG=655863
==========

to

==========
Milo: Pubsub - Trim out pending build states if there are more than 25 per
builder

BUG=655863

Committed:
https://github.com/luci/luci-go/commit/39c1f5c6da051287a0e84f27c6f611181fecb925
==========

[commit-bot: I haz the power, 2016-10-19 22:39:42]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/39c1f5c6da051287a0e84f27c6f611181fecb925