Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 24217002: Add a flag for clang-format that instructs the tool to strip 0 leading slashes from the file names. (Closed)

Created:
7 years, 3 months ago by atreat
Modified:
7 years, 2 months ago
Reviewers:
agable, M-A Ruel, digit1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Add a flag for clang-format that instructs the tool to strip 0 leading slashes from the file names. I have clang-format-3.3 installed and it appears to default to stripping one leading slash. BUG=294188 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
atreat
This patch makes git cl format work for me. I would appreciate it if a ...
7 years, 3 months ago (2013-09-18 14:32:41 UTC) #1
M-A Ruel
Digit wrote this feature without tests and Aaron updated it, so they get to review ...
7 years, 2 months ago (2013-09-26 20:36:59 UTC) #2
digit1
lgtm (I confirm this works on my older install).
7 years, 2 months ago (2013-09-27 08:55:42 UTC) #3
M-A Ruel
lgtm
7 years, 2 months ago (2013-09-27 14:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/24217002/1
7 years, 2 months ago (2013-09-27 14:52:16 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 14:54:06 UTC) #6
Message was sent while issue was closed.
Change committed as 225705

Powered by Google App Engine
This is Rietveld 408576698