Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2421263003: Enable scroll anchoring. (Closed)

Created:
4 years, 2 months ago by skobes
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, ymalik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable scroll anchoring. BUG=657537 Committed: https://crrev.com/6d380ba3ab246a15d6269a75328f481336b53ee1 Cr-Commit-Position: refs/heads/master@{#426337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
skobes
4 years, 2 months ago (2016-10-18 00:26:49 UTC) #4
ojan
lgtm
4 years, 2 months ago (2016-10-18 02:37:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421263003/1
4 years, 2 months ago (2016-10-18 02:37:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/283306)
4 years, 2 months ago (2016-10-18 02:45:43 UTC) #11
skobes
+avi for content/OWNERS
4 years, 2 months ago (2016-10-18 15:51:52 UTC) #13
Avi (use Gerrit)
lgtm 👍
4 years, 2 months ago (2016-10-18 15:55:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421263003/1
4 years, 2 months ago (2016-10-18 16:00:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/283658)
4 years, 2 months ago (2016-10-18 16:08:38 UTC) #18
skobes
+rbyers for API_OWNERS
4 years, 2 months ago (2016-10-18 16:10:34 UTC) #20
Rick Byers
On 2016/10/18 16:10:34, skobes wrote: > +rbyers for API_OWNERS We still need an approved intent-to-ship ...
4 years, 2 months ago (2016-10-19 17:53:56 UTC) #21
skobes
On 2016/10/19 17:53:56, Rick Byers wrote: > On 2016/10/18 16:10:34, skobes wrote: > > +rbyers ...
4 years, 2 months ago (2016-10-19 18:16:20 UTC) #23
Rick Byers
On 2016/10/19 18:16:20, skobes wrote: > On 2016/10/19 17:53:56, Rick Byers wrote: > > On ...
4 years, 2 months ago (2016-10-19 22:01:18 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2421263003/1
4 years, 2 months ago (2016-10-19 22:03:30 UTC) #26
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 23:40:24 UTC) #28
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:13:20 UTC) #30
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d380ba3ab246a15d6269a75328f481336b53ee1
Cr-Commit-Position: refs/heads/master@{#426337}

Powered by Google App Engine
This is Rietveld 408576698