|
|
Chromium Code Reviews
DescriptionEnable scroll anchoring.
BUG=657537
Committed: https://crrev.com/6d380ba3ab246a15d6269a75328f481336b53ee1
Cr-Commit-Position: refs/heads/master@{#426337}
Patch Set 1 #
Messages
Total messages: 30 (15 generated)
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
skobes@chromium.org changed reviewers: + ojan@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ojan@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
skobes@chromium.org changed reviewers: + avi@chromium.org
+avi for content/OWNERS
lgtm 👍
The CQ bit was checked by skobes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
skobes@chromium.org changed reviewers: + rbyers@chromium.org
+rbyers for API_OWNERS
On 2016/10/18 16:10:34, skobes wrote: > +rbyers for API_OWNERS We still need an approved intent-to-ship before shipping this, right?
Description was changed from ========== Enable scroll anchoring. BUG=558575 ========== to ========== Enable scroll anchoring. BUG=657537 ==========
On 2016/10/19 17:53:56, Rick Byers wrote: > On 2016/10/18 16:10:34, skobes wrote: > > +rbyers for API_OWNERS > > We still need an approved intent-to-ship before shipping this, right? I've filed http://crbug.com/657537 capturing the plan per offline discussion, and tagged this patch to that bug.
On 2016/10/19 18:16:20, skobes wrote: > On 2016/10/19 17:53:56, Rick Byers wrote: > > On 2016/10/18 16:10:34, skobes wrote: > > > +rbyers for API_OWNERS > > > > We still need an approved intent-to-ship before shipping this, right? > > I've filed http://crbug.com/657537 capturing the plan per offline discussion, > and tagged this patch to that bug. Thanks, LGTM to ship up until M56 beta. After which bug 657537 tracks either reverting this or getting intent-to-ship approval.
The CQ bit was checked by skobes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable scroll anchoring. BUG=657537 ========== to ========== Enable scroll anchoring. BUG=657537 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable scroll anchoring. BUG=657537 ========== to ========== Enable scroll anchoring. BUG=657537 Committed: https://crrev.com/6d380ba3ab246a15d6269a75328f481336b53ee1 Cr-Commit-Position: refs/heads/master@{#426337} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6d380ba3ab246a15d6269a75328f481336b53ee1 Cr-Commit-Position: refs/heads/master@{#426337} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
