Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 24208003: Add PNACL_CACHE cache backend type, and allow larger files for this type. (Closed)

Created:
7 years, 3 months ago by Derek Schuff
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, native-client-reviews_googlegroups.com, gavinp+disk_chromium.org, pasko
Visibility:
Public.

Description

Add PNACL_CACHE cache backend type, and allow larger files for this type. PnaCl's translation cache is currently using the DISK_CACHE backend, but we don't want to mix the UMA statistics for these caches. Also, because we expect PNaCl's cache to have a small number of files, which will be much larger than most HTTP cache files, we remove the restriction that files can take up no more than 1/8 of the cache. For machines with little available disk space (and thus small caches), this may mean the difference between being able to store any files in the cache, or not. R=rvargas@chromium.org,jvoung@chromium.org BUG=none TEST= unit_tests PnaclTranslationCacheTest.* (and no net_unittests break) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/nacl_host/pnacl_translation_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/cache_type.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/disk_cache/backend_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/histogram_macros.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Derek Schuff
Ricardo: A couple of the other backend types run the backend unit tests a separate ...
7 years, 3 months ago (2013-09-18 18:17:29 UTC) #1
rvargas (doing something else)
net lGTM No, I don't think there is value adding specific DiskCache tests.
7 years, 3 months ago (2013-09-18 19:45:43 UTC) #2
jvoung (off chromium)
lgtm
7 years, 3 months ago (2013-09-18 20:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/24208003/1
7 years, 3 months ago (2013-09-18 23:49:04 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=26221
7 years, 3 months ago (2013-09-18 23:54:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/24208003/1
7 years, 3 months ago (2013-09-19 15:49:36 UTC) #6
commit-bot: I haz the power
Change committed as 224176
7 years, 3 months ago (2013-09-19 18:52:59 UTC) #7
rvargas (doing something else)
7 years, 3 months ago (2013-09-23 17:37:03 UTC) #8
Message was sent while issue was closed.
BTW, now we need descriptions for the new batch of histograms...

Powered by Google App Engine
This is Rietveld 408576698