Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2420393002: Block shelf auto hidden when opt-in IME menu is shown. (Closed)

Created:
4 years, 2 months ago by Azure Wei
Modified:
4 years, 2 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When the opt-in IME menu bubble is shown, we should block the status area's auto hidden behavior. And re-enables the behavior when the bubble is closed. BUG=652625 TEST=Verified on local build. Committed: https://crrev.com/c98ace32e0340aabec2461ca2937ee66fd0d67a6 Cr-Commit-Position: refs/heads/master@{#426383}

Patch Set 1 #

Patch Set 2 : Block shelf auto hide. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M ash/common/system/chromeos/ime_menu/ime_menu_tray.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 1 4 chunks +9 lines, -1 line 0 comments Download
M ash/common/system/status_area_widget.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Azure Wei
Please review this cl. Thanks!
4 years, 2 months ago (2016-10-16 08:01:56 UTC) #3
tdanderson
On 2016/10/16 08:01:56, Azure Wei wrote: > Please review this cl. Thanks! I'm not really ...
4 years, 2 months ago (2016-10-17 14:08:11 UTC) #4
Azure Wei
On 2016/10/17 14:08:11, tdanderson wrote: > On 2016/10/16 08:01:56, Azure Wei wrote: > > Please ...
4 years, 2 months ago (2016-10-19 07:02:20 UTC) #5
tdanderson
Thanks for the update. LGTM
4 years, 2 months ago (2016-10-19 15:47:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2420393002/20001
4 years, 2 months ago (2016-10-20 00:43:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 03:28:20 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:14:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c98ace32e0340aabec2461ca2937ee66fd0d67a6
Cr-Commit-Position: refs/heads/master@{#426383}

Powered by Google App Engine
This is Rietveld 408576698