Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2420063002:
Add flag --single-threaded (Closed)
|
Created:
4 years, 2 months ago by Michael Lippautz Modified:
4 years, 1 month ago CC:
Michael Hablich, v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAdd flag --single-threaded
BUG=
Committed: https://crrev.com/da2f61030cb0c0a4da7fe66e57d0505e62914284
Cr-Commit-Position: refs/heads/master@{#40500}
Patch Set 1 #Patch Set 2 : Fix compile #Messages
Total messages: 23 (12 generated)
Description was changed from ========== Add flag --single-threaded BUG= ========== to ========== Add flag --single-threaded BUG= ==========
mlippautz@chromium.org changed reviewers: + jochen@chromium.org, ulan@chromium.org
wdyt? would it make sense to communicate this flag instead of combinations of --noconcurrent-sweepig and friends to embedders? (asserting is not possible, without introducing a v8 internal wrapper around platform)
we usually just communicate --predictable, won't that work?
lgtm
On 2016/10/14 09:30:26, jochen wrote: > we usually just communicate --predictable, won't that work? Strictly speaking it's even more than single-threaded as e.g. the MemoryReducer can run on the foreground thread in single-threaded use but is not allowed to run in predictable mode.
right, but what's the motivation for adding this flag? Did some embedder explicitly ask for no threads, but still wants the memory reducer tasks?
after offline discussion, this lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2420063002/#ps20001 (title: "Fix compile")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add flag --single-threaded BUG= ========== to ========== Add flag --single-threaded BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add flag --single-threaded BUG= ========== to ========== Add flag --single-threaded BUG= Committed: https://crrev.com/da2f61030cb0c0a4da7fe66e57d0505e62914284 Cr-Commit-Position: refs/heads/master@{#40500} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/da2f61030cb0c0a4da7fe66e57d0505e62914284 Cr-Commit-Position: refs/heads/master@{#40500} |
