RenderLayerBacking::startAnimation() return value has incorrect semantic

RenderLayerBacking::startAnimation() return value has incorrect semantic

This CL is based on Shawn Singh's work: webkit.org/b/94993

RenderLayerBacking::startAnimation() was returning true whenever
*any* property of an animation was accepted for accelerated
animation by the compositor. However, the rest of the code outside
this was using the return value to indicate that *all* properties
were accepted for accelerated animation.

BUG=143658
TEST=compositing/animation/two-properties-in-keyframed-animation.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158325

[dshwang, 2013-09-20 08:54:58]

@shawnsingh requested me to apply https://bugs.webkit.org/show_bug.cgi?id=94993
in https://codereview.chromium.org/23431021/
So I did it. :)

@shawnsingh almost got this CL done. I changed little.
Combination with transform and filter animations can reproduce this bug. Before
this CL, png of
virtual/threaded/animations/two-properties-in-keyframed-animation.html is just
black box. After this CL, everything is fine.

[shawnsingh, 2013-09-20 09:10:29]

Well, as much as it's reasonable for me to review my own old patch... LGTM =) 
Thank you very much for doing this!  Greatly appreciated.

[commit-bot: I haz the power, 2013-09-20 09:25:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/24198009/1

[dshwang, 2013-09-20 09:25:03]

On 2013/09/20 09:10:29, shawnsingh wrote:
> Well, as much as it's reasonable for me to review my own old patch... LGTM =) 
> Thank you very much for doing this!  Greatly appreciated.

It's my pleasure. Thank you for your review ;)

[commit-bot: I haz the power, 2013-09-20 09:38:15]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[dshwang, 2013-09-20 09:39:12]

On 2013/09/20 09:38:15, I haz the power (commit-bot) wrote:
> Retried try job too often on blink_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

@jamesr, @Ian, could you review please?

Missing LGTM from an OWNER for these files:
    Source/core/rendering/RenderLayerBacking.cpp

[Ian Vollick, 2013-09-20 14:44:18]

On 2013/09/20 09:39:12, dshwang wrote:
> On 2013/09/20 09:38:15, I haz the power (commit-bot) wrote:
> > Retried try job too often on blink_presubmit for step(s) presubmit
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...
> 
> @jamesr, @Ian, could you review please?
> 
> Missing LGTM from an OWNER for these files:
>     Source/core/rendering/RenderLayerBacking.cpp

Nice! lgtm

[commit-bot: I haz the power, 2013-09-20 14:44:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/24198009/1

[Ian Vollick, 2013-09-20 14:57:41]

On 2013/09/20 14:44:35, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/dongseong.hwang%40intel.com/24198009/1

I like this change to startAnimation, but it looks like startTransition could
use the same love. Perhaps this could be done in a follow up?

[dshwang, 2013-09-20 15:35:55]

On 2013/09/20 14:57:41, Ian Vollick wrote:
> I like this change to startAnimation, but it looks like startTransition could
> use the same love. Perhaps this could be done in a follow up?

Yes, I'm already fixing it. I also recognized it a hour ago :)

[commit-bot: I haz the power, 2013-09-20 16:13:04]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-09-20 16:26:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/24198009/1

[dshwang, 2013-09-20 17:51:53]

Submit patch set 2: Mark
virtual/web-animations-css/animations/two-properties-in-keyframed-animation.html
to Failure because web-animations-css does not support filter animation yet.
This CL will be landed after crrev.com/24087006

[dshwang, 2013-09-25 12:13:45]

web-animations-css does not support filter animation yet, so
virtual/web-animations-css/animations/two-properties-in-keyframed-animation.html
crash
As @alancutter suggested in crrev.com/24087006/#msg10, this CL marks the test
Crash to land.

[commit-bot: I haz the power, 2013-09-25 12:14:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/24198009/34001

[commit-bot: I haz the power, 2013-09-25 13:25:51]

Change committed as 158325