Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2419793003: media: Use native video enum types in media mojo interfaces (Closed)

Created:
4 years, 2 months ago by xhwang
Modified:
4 years, 2 months ago
Reviewers:
jrummell, mcasas, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, alokp+watch_chromium.org, darin (slow to review), Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Use native video enum types in media mojo interfaces TBR=jrummell@chromium.org, mcasas@chromium.org BUG=611224, 655205 TEST=mojo_media_unittests still pass Committed: https://crrev.com/241b69ba796c61166b60dcc7b0fa09dfd7b3b49c Cr-Commit-Position: refs/heads/master@{#425275}

Patch Set 1 : media: Use native video enum types in media mojo interfaces #

Patch Set 2 : media: Use native video enum types in media mojo interfaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -220 lines) Patch
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/video_capture.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/ipc/media_param_traits_macros.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M media/gpu/ipc/common/media_param_traits_macros.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 5 chunks +10 lines, -118 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 3 chunks +13 lines, -89 lines 0 comments Download
M media/mojo/interfaces/media_types.typemap View 2 chunks +6 lines, -0 lines 0 comments Download
M services/video_capture/public/interfaces/video_capture_format.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/public/interfaces/video_capture_format_traits.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (24 generated)
xhwang
PTAL
4 years, 2 months ago (2016-10-14 07:12:41 UTC) #16
dcheng
LGTM
4 years, 2 months ago (2016-10-14 07:49:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419793003/80001
4 years, 2 months ago (2016-10-14 07:54:57 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 2 months ago (2016-10-14 08:49:39 UTC) #27
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:52:03 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/241b69ba796c61166b60dcc7b0fa09dfd7b3b49c
Cr-Commit-Position: refs/heads/master@{#425275}

Powered by Google App Engine
This is Rietveld 408576698