third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc - Issue 2419793002: [Reland] Optimize blink scheduler with an intrusive heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc

Issue 2419793002: [Reland] Optimize blink scheduler with an intrusive heap (Closed)

Patch Set: Fixed perf test and increaced test coverage Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc

index e0dfe3851859fc5d75d3328c45f30b9cb9adff61..20d07dd36e65bb4ddb313cc793c4197ff7b1912b 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc

@@ -79,8 +79,8 @@ TEST_F(WorkQueueSetsTest, OnPushQueue) {

EXPECT_FALSE(

work_queue_sets_->GetOldestQueueInSet(set, &selected_work_queue));

+ // Calls OnPushQueue.

work_queue->Push(FakeTaskWithEnqueueOrder(10));

- work_queue_sets_->OnPushQueue(work_queue);

EXPECT_TRUE(work_queue_sets_->GetOldestQueueInSet(set, &selected_work_queue));

EXPECT_EQ(work_queue, selected_work_queue);

@@ -139,9 +139,9 @@ TEST_F(WorkQueueSetsTest, OnPopQueue) {

}

TEST_F(WorkQueueSetsTest, OnPopQueue_QueueBecomesEmpty) {

- WorkQueue* queue1 = NewTaskQueue("queue");

- WorkQueue* queue2 = NewTaskQueue("queue");

- WorkQueue* queue3 = NewTaskQueue("queue");

+ WorkQueue* queue1 = NewTaskQueue("queue1");

+ WorkQueue* queue2 = NewTaskQueue("queue2");

+ WorkQueue* queue3 = NewTaskQueue("queue3");

queue1->Push(FakeTaskWithEnqueueOrder(6));

queue2->Push(FakeTaskWithEnqueueOrder(5));

queue3->Push(FakeTaskWithEnqueueOrder(4));