Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/api_test/webnavigation/test_history.js

Issue 24197002: Don't send the oncompleted signal twice in the webnavigation API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/data/extensions/api_test/webnavigation/history/c.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 onload = function() { 5 onload = function() {
6 var getURL = chrome.extension.getURL; 6 var getURL = chrome.extension.getURL;
7 chrome.tabs.create({"url": "about:blank"}, function(tab) { 7 chrome.tabs.create({"url": "about:blank"}, function(tab) {
8 var tabId = tab.id; 8 var tabId = tab.id;
9 9
10 chrome.test.runTests([ 10 chrome.test.runTests([
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 details: { frameId: 0, 47 details: { frameId: 0,
48 processId: 0, 48 processId: 0,
49 tabId: 0, 49 tabId: 0,
50 timeStamp: 0, 50 timeStamp: 0,
51 transitionQualifiers: [], 51 transitionQualifiers: [],
52 transitionType: "link", 52 transitionType: "link",
53 url: getURL('history/b.html') }}], 53 url: getURL('history/b.html') }}],
54 [ navigationOrder("a-") ]); 54 [ navigationOrder("a-") ]);
55 chrome.tabs.update(tabId, { url: getURL('history/a.html') }); 55 chrome.tabs.update(tabId, { url: getURL('history/a.html') });
56 }, 56 },
57
58 // Manipulating history before parsing completed.
59 function historyBeforeParsing() {
60 expect([
61 { label: "a-onBeforeNavigate",
62 event: "onBeforeNavigate",
63 details: { frameId: 0,
64 parentFrameId: -1,
65 processId: 0,
66 tabId: 0,
67 timeStamp: 0,
68 url: getURL('history/c.html') }},
69 { label: "a-onCommitted",
70 event: "onCommitted",
71 details: { frameId: 0,
72 processId: 0,
73 tabId: 0,
74 timeStamp: 0,
75 transitionQualifiers: [],
76 transitionType: "link",
77 url: getURL('history/c.html') }},
78 { label: "a-onHistoryStateUpdated",
79 event: "onHistoryStateUpdated",
80 details: { frameId: 0,
81 processId: 0,
82 tabId: 0,
83 timeStamp: 0,
84 transitionQualifiers: [],
85 transitionType: "link",
86 url: getURL('history/d.html') }},
87 { label: "a-onDOMContentLoaded",
88 event: "onDOMContentLoaded",
89 details: { frameId: 0,
90 processId: 0,
91 tabId: 0,
92 timeStamp: 0,
93 url: getURL('history/d.html') }},
94 { label: "a-onCompleted",
95 event: "onCompleted",
96 details: { frameId: 0,
97 processId: 0,
98 tabId: 0,
99 timeStamp: 0,
100 url: getURL('history/d.html') }}],
101 [ navigationOrder("a-"),
102 [ 'a-onCommitted',
103 'a-onHistoryStateUpdated',
104 'a-onDOMContentLoaded']]);
105 chrome.tabs.update(tabId, { url: getURL('history/c.html') });
106 },
57 ]); 107 ]);
58 }); 108 });
59 }; 109 };
OLDNEW
« no previous file with comments | « chrome/test/data/extensions/api_test/webnavigation/history/c.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698