Dump only salient differences from env_dump.py.

Dump only salient differences from env_dump.py.

NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223904

[iannucci, 2013-09-18 00:55:37]

lgtm % things

https://chromiumcodereview.appspot.com/24195006/diff/3001/build/env_dump.py
File build/env_dump.py (right):

https://chromiumcodereview.appspot.com/24195006/diff/3001/build/env_dump.py#n...
build/env_dump.py:23: help='Dump the environment to sys.stdout and exit
immediately.')
just 'stdout' in help string :)

https://chromiumcodereview.appspot.com/24195006/diff/3001/build/env_dump.py#n...
build/env_dump.py:27: parser.error('Requires --output-json option.')
we should move this error into the 'else' clause below

https://chromiumcodereview.appspot.com/24195006/diff/3001/build/env_dump.py#n...
build/env_dump.py:29: if options.dump_mode:
we should make it an error to pass options.output_json here

https://chromiumcodereview.appspot.com/24195006/diff/3001/build/env_dump.py#n...
build/env_dump.py:37: '. %s; %s -d -f %s' % (envsetup_cmd,
os.path.abspath(__file__),
I don't think we need to pass -f any more, since it's ignored.

https://chromiumcodereview.appspot.com/24195006/diff/3001/build/env_dump.py#n...
build/env_dump.py:43: sys.exit('Error running % and dumping environment.' %
envsetup_cmd)
missing %s

[Siva Chandra, 2013-09-18 01:28:05]

PTAL

[iannucci, 2013-09-18 17:59:08]

lgtm

[commit-bot: I haz the power, 2013-09-18 17:59:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sivachandra@chromium.org/24195006/8001

[commit-bot: I haz the power, 2013-09-18 18:01:32]

Change committed as 223904