Mention withCredentials attribute in the error message about CORS check failure

Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

R=yhirano@chromium.org
BUG=566239
Committed: https://crrev.com/49a0d064be13af14d84df7de0fc632820b4701d9
Cr-Commit-Position: refs/heads/master@{#426494}

[tyoshino (SeeGerritForStatus), 2016-10-14 14:02:18]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 14:02:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 15:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 15:29:32]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-10-17 05:06:13]

Description was changed from

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

BUG=566239
==========

to

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

BUG=566239
==========

[tyoshino (SeeGerritForStatus), 2016-10-17 05:06:13]

tyoshino@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2016-10-20 04:55:52]

https://codereview.chromium.org/2419063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp (right):

https://codereview.chromium.org/2419063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp:257: "The
request's credentials flag (determined by withCredentials for "
Strictly speaking, "credentials mode" is set on a (concept) request and
"credentials flag" is set on a fetch operation.

[tyoshino (SeeGerritForStatus), 2016-10-20 10:36:33]

https://codereview.chromium.org/2419063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp (right):

https://codereview.chromium.org/2419063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp:257: "The
request's credentials flag (determined by withCredentials for "
On 2016/10/20 04:55:52, yhirano wrote:
> Strictly speaking, "credentials mode" is set on a (concept) request and
> "credentials flag" is set on a fetch operation.

Good catch. I'll rephrase "request's". Regarding use of credentials flag than
credentials mode, credentials mode is better in terms of correspondence with the
spec, but I refrained from using it as |includeCredentials| here corresponds to
the credentials flag. But I'm going to clean up the StoredCredentials enum soon.
So, I can fix this in advance.

[yhirano, 2016-10-20 10:54:53]

lgtm

[tyoshino (SeeGerritForStatus), 2016-10-20 14:34:49]

Description was changed from

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

BUG=566239
==========

to

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

R=yhirano@chromium.org
BUG=566239
==========

[tyoshino (SeeGerritForStatus), 2016-10-20 14:34:53]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2016-10-20 14:35:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 16:23:48]

Description was changed from

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

R=yhirano@chromium.org
BUG=566239
==========

to

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

R=yhirano@chromium.org
BUG=566239
==========

[commit-bot: I haz the power, 2016-10-20 16:23:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:18:52]

Description was changed from

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

R=yhirano@chromium.org
BUG=566239
==========

to

==========
Mention withCredentials attribute in the error message about CORS check failure

The spec phrase "credentials flag" is not so useful for those who are
not familiar with the Fetch spec. Mention the withCredentials attribute
so that XHR users can understand what's wrong with their code easily.

I tried to show this only for XHR by using the RequestContext value,
but RequestContextXMLHttpRequest is used not only for XHR but for
EventSource. So, I refrained from taking the approach.

R=yhirano@chromium.org
BUG=566239

Committed: https://crrev.com/49a0d064be13af14d84df7de0fc632820b4701d9
Cr-Commit-Position: refs/heads/master@{#426494}
==========

[commit-bot: I haz the power, 2016-10-21 13:18:52]

Patchset 2 (id:??) landed as
https://crrev.com/49a0d064be13af14d84df7de0fc632820b4701d9
Cr-Commit-Position: refs/heads/master@{#426494}