[Reland] Refactoring of SBER preference usage

[Reland] Refactoring of SBER preference usage, this time without introducing a static initializer in preference_api.

This reverts commit 5ddd173bd9aef153574bbe4639fa190780c65348.

[Original CL description]
Refactoring usage of SBER preference.

Moved (most of) the references of this pref into a shared util file, and
updated
calling code to use it.

The vast majority of the code just cares about whether the opt-in is on
or off.
A handful of other code (mostly unittests) need the name of the pref so
they can
set it.

The primary outliers are 1) profile.cc (where the pref is
first registered by name), and 2) safe_browsing_service.cc (where it
listens for
changes to the pref). These may be handled in future refactoring.

BUG=653122
Committed: https://crrev.com/cc1c0ce3a7ee43e7f4b87620899c0b7a41d2a9da
Cr-Commit-Position: refs/heads/master@{#426565}

[lpz, 2016-10-13 14:42:49]

Description was changed from

==========
[Reland] Refactoring of SBER preference usage, this time without introducing a
static initializer in preference_api.

This reverts commit 5ddd173bd9aef153574bbe4639fa190780c65348.

[Original CL description]
Refactoring usage of SBER preference.

Moved (most of) the references of this pref into a shared util file, and
updated
calling code to use it.

The vast majority of the code just cares about whether the opt-in is on
or off.
A handful of other code (mostly unittests) need the name of the pref so
they can
set it.

The primary outliers are 1) profile.cc (where the pref is
first registered by name), and 2) safe_browsing_service.cc (where it
listens for
changes to the pref). These may be handled in future refactoring.

BUG=653122
==========

to

==========
[Reland] Refactoring of SBER preference usage, this time without introducing a
static initializer in preference_api.

This reverts commit 5ddd173bd9aef153574bbe4639fa190780c65348.

[Original CL description]
Refactoring usage of SBER preference.

Moved (most of) the references of this pref into a shared util file, and
updated
calling code to use it.

The vast majority of the code just cares about whether the opt-in is on
or off.
A handful of other code (mostly unittests) need the name of the pref so
they can
set it.

The primary outliers are 1) profile.cc (where the pref is
first registered by name), and 2) safe_browsing_service.cc (where it
listens for
changes to the pref). These may be handled in future refactoring.

BUG=653122
==========

[lpz, 2016-10-13 15:22:31]

The CQ bit was checked by lpz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 15:22:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpz, 2016-10-13 15:23:25]

lpz@chromium.org changed reviewers:
+ lazyboy@chromium.org

[commit-bot: I haz the power, 2016-10-13 16:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 16:24:44]

Dry run: This issue passed the CQ dry run.

[lpz, 2016-10-13 16:59:12]

lazyboy@: please review c/b/extensions. I opted for a quick-fix just to reland
this CL but will do a follow-up with the refactoring we discussed offline.

[lpz, 2016-10-13 17:01:42]

lpz@chromium.org changed reviewers:
+ estark@chromium.org, jialiul@chromium.org, miguelg@chromium.org,
mlerman@chromium.org, msw@chromium.org

[lpz, 2016-10-13 17:01:43]

miguelg@chromium.org: Please review changes in c/b/android/preferences

mlerman@chromium.org: Please review changes in c/b/profiles

msw@chromium.org: Please review changes in c/b/ui/views

estark@chromium.org: Please review changes in c/b/interstitials, c/b/ssl

jialiul@chromium.org: Please review changes in c/b/safe_browsing

[Jialiu Lin, 2016-10-13 17:07:42]

lgtm for c/b/safe_browsing

[msw, 2016-10-13 17:14:56]

c/b/ui/views lgtm

[Mike Lerman, 2016-10-13 18:21:05]

c/b/profiles LGTM

[estark, 2016-10-13 21:11:17]

c/b/interstitials and c/b/ssl lgtm

[lazyboy, 2016-10-13 21:20:59]

one quick q.

https://codereview.chromium.org/2418813002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/preference/preference_api.cc (right):

https://codereview.chromium.org/2418813002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/preference/preference_api.cc:117:
prefs::kSafeBrowsingExtendedReportingEnabled, APIPermission::kPrivacy,
I thought you wanted dynamic name here, is it not the case anymore? or are you
planning to do that separately?

[lpz, 2016-10-13 22:27:34]

https://codereview.chromium.org/2418813002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/preference/preference_api.cc (right):

https://codereview.chromium.org/2418813002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/preference/preference_api.cc:117:
prefs::kSafeBrowsingExtendedReportingEnabled, APIPermission::kPrivacy,
On 2016/10/13 21:20:59, lazyboy wrote:
> I thought you wanted dynamic name here, is it not the case anymore? or are you
> planning to do that separately?

I'll do it separately, since this CL is big enough.

[lazyboy, 2016-10-13 22:30:17]

sgtm, c/b/extensions lgtm.

[lpz, 2016-10-17 17:34:16]

lpz@chromium.org changed reviewers:
+ gab@chromium.org

[lpz, 2016-10-17 17:34:16]

+gab to review newly added DEP on components/prefs

[gab, 2016-10-17 19:27:12]

On 2016/10/17 17:34:16, lpz wrote:
> +gab to review newly added DEP on components/prefs

Referring to prefs::kSafeBrowsingExtendedReportingEnabled in diff? This is a
mere constant, doesn't require owners review like a DEPS does.

Also, pro-tip: you can re-open a CL via "Edit issue", this is preferred to
re-uploading a new CL.

Otherwise re-lgtm for DEPS addition in components/safe_browsing_db/DEPS (and
that's why re-using the same CL is preferred, you can re-ride old lgtms for
things that haven't changed)

[lpz, 2016-10-18 14:36:58]

The CQ bit was checked by lpz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 14:37:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 16:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 16:35:39]

Dry run: This issue passed the CQ dry run.

[lpz, 2016-10-18 17:21:12]

The CQ bit was checked by lpz@chromium.org

[lpz, 2016-10-18 17:21:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlerman@chromium.org, msw@chromium.org, lazyboy@chromium.org,
jialiul@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2418813002/#ps40001
(title: "Sync to head")

[commit-bot: I haz the power, 2016-10-18 17:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:27:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lpz, 2016-10-18 17:32:32]

lpz@chromium.org changed reviewers:
+ dtrainor@chromium.org

[lpz, 2016-10-18 17:33:14]

On 2016/10/17 19:27:12, gab wrote:
> On 2016/10/17 17:34:16, lpz wrote:
> > +gab to review newly added DEP on components/prefs
> 
> Referring to prefs::kSafeBrowsingExtendedReportingEnabled in diff? This is a
> mere constant, doesn't require owners review like a DEPS does.
> 
> Also, pro-tip: you can re-open a CL via "Edit issue", this is preferred to
> re-uploading a new CL.
> 
> Otherwise re-lgtm for DEPS addition in components/safe_browsing_db/DEPS (and
> that's why re-using the same CL is preferred, you can re-ride old lgtms for
> things that haven't changed)

Ooh, great to know for next time. Thanks!

[lpz, 2016-10-18 17:33:47]

+dtrainor for c/b/android/preferences

[lpz, 2016-10-20 00:24:10]

The CQ bit was checked by lpz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 00:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 02:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 02:41:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lpz, 2016-10-20 15:19:52]

The CQ bit was checked by lpz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 15:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2016-10-20 15:23:16]

lgtm for chrome/browser/android/preferences/pref_service_bridge.cc

[commit-bot: I haz the power, 2016-10-20 16:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:22:39]

Dry run: This issue passed the CQ dry run.

[lpz, 2016-10-20 18:10:47]

The CQ bit was checked by lpz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 18:11:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:32:18]

Dry run: This issue passed the CQ dry run.

[lpz, 2016-10-20 19:32:47]

The CQ bit was checked by lpz@chromium.org

[lpz, 2016-10-20 19:32:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlerman@chromium.org, miguelg@chromium.org, msw@chromium.org,
lazyboy@chromium.org, jialiul@chromium.org, estark@chromium.org,
gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2418813002/#ps60001
(title: "Sync")

[commit-bot: I haz the power, 2016-10-20 19:33:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:43:00]

Description was changed from

==========
[Reland] Refactoring of SBER preference usage, this time without introducing a
static initializer in preference_api.

This reverts commit 5ddd173bd9aef153574bbe4639fa190780c65348.

[Original CL description]
Refactoring usage of SBER preference.

Moved (most of) the references of this pref into a shared util file, and
updated
calling code to use it.

The vast majority of the code just cares about whether the opt-in is on
or off.
A handful of other code (mostly unittests) need the name of the pref so
they can
set it.

The primary outliers are 1) profile.cc (where the pref is
first registered by name), and 2) safe_browsing_service.cc (where it
listens for
changes to the pref). These may be handled in future refactoring.

BUG=653122
==========

to

==========
[Reland] Refactoring of SBER preference usage, this time without introducing a
static initializer in preference_api.

This reverts commit 5ddd173bd9aef153574bbe4639fa190780c65348.

[Original CL description]
Refactoring usage of SBER preference.

Moved (most of) the references of this pref into a shared util file, and
updated
calling code to use it.

The vast majority of the code just cares about whether the opt-in is on
or off.
A handful of other code (mostly unittests) need the name of the pref so
they can
set it.

The primary outliers are 1) profile.cc (where the pref is
first registered by name), and 2) safe_browsing_service.cc (where it
listens for
changes to the pref). These may be handled in future refactoring.

BUG=653122
==========

[commit-bot: I haz the power, 2016-10-20 19:43:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:21:24]

Description was changed from

==========
[Reland] Refactoring of SBER preference usage, this time without introducing a
static initializer in preference_api.

This reverts commit 5ddd173bd9aef153574bbe4639fa190780c65348.

[Original CL description]
Refactoring usage of SBER preference.

Moved (most of) the references of this pref into a shared util file, and
updated
calling code to use it.

The vast majority of the code just cares about whether the opt-in is on
or off.
A handful of other code (mostly unittests) need the name of the pref so
they can
set it.

The primary outliers are 1) profile.cc (where the pref is
first registered by name), and 2) safe_browsing_service.cc (where it
listens for
changes to the pref). These may be handled in future refactoring.

BUG=653122
==========

to

==========
[Reland] Refactoring of SBER preference usage, this time without introducing a
static initializer in preference_api.

This reverts commit 5ddd173bd9aef153574bbe4639fa190780c65348.

[Original CL description]
Refactoring usage of SBER preference.

Moved (most of) the references of this pref into a shared util file, and
updated
calling code to use it.

The vast majority of the code just cares about whether the opt-in is on
or off.
A handful of other code (mostly unittests) need the name of the pref so
they can
set it.

The primary outliers are 1) profile.cc (where the pref is
first registered by name), and 2) safe_browsing_service.cc (where it
listens for
changes to the pref). These may be handled in future refactoring.

BUG=653122

Committed: https://crrev.com/cc1c0ce3a7ee43e7f4b87620899c0b7a41d2a9da
Cr-Commit-Position: refs/heads/master@{#426565}
==========

[commit-bot: I haz the power, 2016-10-21 13:21:25]

Patchset 4 (id:??) landed as
https://crrev.com/cc1c0ce3a7ee43e7f4b87620899c0b7a41d2a9da
Cr-Commit-Position: refs/heads/master@{#426565}

[David Trainor- moved to gerrit, 2016-10-21 16:18:41]

lgtm.  sorry for the delay.