Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 24188002: Fix a memory leak in message_center_settings_controller.cc. (Closed)

Created:
7 years, 3 months ago by Alexei Svitkine (slow)
Modified:
7 years, 3 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a memory leak in message_center_settings_controller.cc. Found by the Mac OS X 'leaks' tool; fixed on a plane. BUG=292905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223503

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/notifications/message_center_settings_controller.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
7 years, 3 months ago (2013-09-16 21:00:05 UTC) #1
dewittj
Thanks! This will be fixed when crrev.com/23904007 lands.
7 years, 3 months ago (2013-09-16 21:01:57 UTC) #2
dewittj
actually if you want to just land this now, that lgtm. Optionally remove the braces ...
7 years, 3 months ago (2013-09-16 21:12:22 UTC) #3
Alexei Svitkine (slow)
ok braces removed
7 years, 3 months ago (2013-09-16 21:13:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/24188002/21001
7 years, 3 months ago (2013-09-16 21:14:19 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 01:34:23 UTC) #6
Message was sent while issue was closed.
Change committed as 223503

Powered by Google App Engine
This is Rietveld 408576698